Repository navigation
Prebuild only the apps that open as a process - #553
Merged
Merged
Conversation
The checkout prebuild planned a release build for every listed catalog app, including the linked modules this shell opens in-process (Calculator, Clock, Notes, Reminders and Weather on macOS): five builds no launch would ever start, run before the apps people open as a process got their turn on a fresh checkout. The plan now leaves out every app a launch would host in-process, by the rule launch_app_with_args applies (hosting Module and a linked module). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checkout prebuild (#549) now builds only the apps that open as a process. It skips the linked modules the shell hosts in-process.
Why
The prebuild planned a release build for every listed catalog app. On macOS that includes Calculator, Clock, Notes, Reminders and Weather, which are linked modules: a launch opens them in-process (
wm: launched clock as client 1 (in-process, clock)), so their process build never runs.That made five wasted builds on a fresh checkout, or after a main update changes Makepad. They ran one at a time at background priority before the apps people open as processes got their turn. On 19 Oct, calculator alone took 3.8 min cold. The prebuild log listed 15 apps where 10 can use the build.
What changes
prebuild::startandprebuild::plantake anin_processpredicate and leave out every app it accepts. The WM passes the rulelaunch_app_with_argsuses to open an app in-process:apps.hosting(id) == Hosting::Moduleand a linked module for it.prebuild.rsmodule docs.Testing
phone/:cargo test --locked --features mobile-apps -p octosense-shell --lib -- prebuild::tests clients::tests: 50 passed. The new test isan_app_hosted_in_process_is_not_prebuilt.cargo check --locked -p octosense.prebuild.rschanges included): a hidden shell on a scratch profile logsprebuild: 10 catalog apps build in the background: reference, browser, files, terminal, task, sheets, finance, route, image, pdf. Before, it listed 15 apps, including calculator, clock, notes, reminders and weather; the same run logs those as linked modules. The merged tree also passedcargo test --locked --features mobile-apps -p octosense-shell --lib -- prebuild::tests clients::tests octosense::catalog::tests(56 passed) andcargo build --locked -p octosense.It touches
prebuild.rsin places #552 doesn't; whichever lands second merges main in.🤖 Generated with Claude Code