Repository navigation
Quick Deck: Present takes the whole screen (window.fullscreen) - #550
Merged
Merged
Conversation
The Present tap now asks the shell for full screen (#520's window.fullscreen), so the show covers the whole screen instead of only the app's area inside its window. Where the host can't (card-host, a phone, a refused request) the show fills the window as before. - start_present asks {on: true} once the show has started, within the 5 seconds a press counts for. - show() gives the screen back ({on: false}) whenever Present is over, however it ended: Exit, the corner control or the end of the show. - on_app_fullscreen(false), from Esc, Cmd+F or another window, ends Present; on_app_fullscreen(true) after Present already ended gives the screen straight back. - A slide drawn for the smaller window is drawn again at the full-screen stage width (present.px); the stretched picture shows until then. tests/ui.py: the shell journey checks that Present covers the whole window and that the window comes back, by Exit in the light pass and by Esc in the dark one; the playback journey waits for the full screen and a settled stage before it measures the clip's box. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Local CI passed on bff731c ( GitHub would run for this PR: desktop.yml, phone.yml, apps.yml. Merged on this local pass (macOS runner queue); GitHub CI runs on the merge commit on main.
Skipped (these did NOT pass; (!) marks a skip that blocks tools/ci-local-merge.sh):
Notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick Deck's Present now takes the whole screen. The Present tap asks the shell for full screen through #520's
window.fullscreen, so the show covers the screen instead of only the app's area inside its window. Where the host can't do that (card-host, a phone, a refused request), the show fills the window as before.Only Quick Deck files change:
bundle/main.splash, both READMEs andtests/ui.py.What changes
start_presentasks{on: true}once the show has started, within the 5 seconds a press counts for.show()gives the screen back ({on: false}) whenever Present is over, however it ended: Exit, the corner control or the end of the show.on_app_fullscreen(false)ends Present when Esc, ⌘F or another window ends the full screen.on_app_fullscreen(true)after Present already ended gives the screen straight back.present.px). The stretched picture shows until then.tests/ui.py:Verified
python3 apps/quickdeck/tests/ui.py --only shell: passed light and dark. The window [54, 76, 1292, 662] went to [0, 0, 1400, 900] for Present and came back (within a point), by Exit in the light pass and by Esc in the dark one.python3 apps/quickdeck/tests/ui.py --only playback: passed light and dark: the autoplay clip and the.pptxcopy's tapped clip play in Present full screen (two grabs a second apart differ over the clip's box).Not covered
window.fullscreenis a no-op there (window.fullscreen: an app's own window in presentation full screen, from a tap #520), so the show fills the window as before. Not re-run on a device.🤖 Generated with Claude Code