Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Confirming the Daycast family-weather reminder opens Rinx's native send-prompt flow, then Rinx stops with a draw panic. The shell log reports the hosted Rinx module panicking in draw with
called Option::unwrap() on a None value; this occurs before a provider reply is involved.A hosted Splash module's Root belongs to its isolated VM. Makepad's current
set_ui_rootpath stores that VM-ownedWidgetRefin the process-global widget tree, so a hosted app can replace the host's root and leave the shell with an invalid widget handle.Change
ShowPrompt,HidePrompt, andShowPrompt.Validation
cargo test --locked --offline --release -p octosense-shell --lib --no-default-features --features app-rinx rinx_reminder_confirmation_does_not_stop_the_module -- --nocapturepassed (1 test).git diff --checkpassed.python tools/setup.py --check --cargocould not run because the local Makepad checkout has local changes; the exact overlay is recorded inruntime-patches.lock.jsonfor CI to verify.Fixes #536