Repository navigation
Quick Deck: the inspector shows the deck's own states (#507) - #508
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Theme tab marks the deck's colour set and font pair (deck.open and deck.state's color_scheme and font_scheme; a built-in theme's own pair by its families) and shows every colour set's colours and the deck's real footer; the Format tab's Box switches show the box's anchor and autofit (deck.format_state); a chart's elements and palette and a table's options (now all six) show deck.slide's values. A change shows at once and the service's next answer replaces it. After Undo or Redo, and after any design change, deck.state and deck.slide bring the deck's own values back without reopening, and the inspector keeps its scroll (refresh_view) so the control just used stays in view. The Fonts hint follows a theme change, a .docx or .xlsx refused as unsupported: is explained, and each segment, colour set, font pair and palette says whether it's chosen (View.selected) for tools. The pixel maps' notes follow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The dev fixture answers #507's fields as the service does (colour sets with their colours, the deck's colour set, font pair and footer, a box's anchor and autofit, a chart's legend, data labels, gridlines and palette, a table's options) and keeps an undo history of the deck's data. ui.py's fixture journey checks the switches and marks against it, adds the table's and the footer's controls, and checks a change and its Undo; the shell journey's light pass changes a box's anchor and autofit, a chart's data labels, a table's total row, the colour set and the footer, reads each back from the engine and checks each Undo. --bundle and --grabs-only take another bundle's frames for a before and after. The model tests cover the new rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both READMEs say what the inspector shows and how the runs check it; tests/evidence/inspector-states-20261011 holds the designs beside the app for 02, 03 and 05, main's app beside this branch's for those and the table's and footer's controls, the real engine's frames of each state following a change and its undo, and a receipt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Local CI passed on 228958c ( GitHub would run for this PR: desktop.yml, phone.yml, apps.yml. Merged on this local pass (macOS runner queue); GitHub CI runs on the merge commit on main.
Skipped (these did NOT pass; (!) marks a skip that blocks tools/ci-local-merge.sh):
Notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Quick Deck v2 (#506) showed some inspector controls as off, or marked them by guessing, because the deck service didn't report their state:
#507 (merged as eb2fd5d) now reports all of these. This PR makes the controls show them, and keeps them showing the deck's own values after an Undo or a Redo. The maintainer has already approved the look; nothing is redesigned.
What
SERVICE.md: the inspector states (#507)appends the coordinator's section, verbatim, as its own commit.deck.openanddeck.state. A built-in theme's own font pair is named after the theme, so the pair with the same families is marked (Harbor's fonts are Classic's).deck.open's missing fonts.deck.format_state'sanchorandautofit, with hints forresize,justifiedanddistributed.deck.slide's values. On main, a chart without a legend showed Legend on.deck.slide's values (main showed three, at their defaults).deck.stateanddeck.slidebring the deck's own values back without reopening.refresh_view), so the control just used stays in view. Before, it jumped to the top..docxor.xlsxrefused asunsupported:is explained in words.View.selected), so the tests can read them.Tests
cargo test --locked -p octosense-shell --lib quickdeck_modelpasses 27. With--features app-hubit passes 28.card-host(macOS, 64 ms budget):fixtureandstatespass, light and dark, with no overrun in the final run.shellpasses, light then dark, thenrestart. There are no script errors and no overruns, only the four harmlessscript_result droppedwarnings seen before.deck.stateagain), undone, and read back once more:apps/quickdeck/tests/evidence/inspector-states-20261011/receipt.json.script time budget exceededeach, right after a PNG decode: an earlier dark fixture session, and onestates-fullrun.Frames (in
apps/quickdeck/tests/evidence/inspector-states-20261011/)before-after/02-edit-text.png,03-chart.png,05-theme.png,11-table.png,12-footer.png, plus thed…dark versions. Main's app is on the left, this branch on the right, both on the same fixture.fixture/02-edit-text.png,03-chart.png,05-theme.pngand the dark versions. These refresh v2'sv2-20261011/fixture/sheets for the screens that change.linux/10-box.pngand10b-box-undone.png,11-chartand11b,12-tableand12b,13-coloursand13b,14-footerand14b.linux/states.jsonrecords what the engine first reported.Not verified
justifiedordistributedanchors, orresizeautofit..docxor.xlsxfrom the device: the file dialog can't be driven in a hidden window.🤖 Generated with Claude Code