Repository navigation
rom tests: IME harness stubs follow the pinned makepad - #483
Merged
Merged
Conversation
Two `test_android_ime_handoff` tests splice methods from the pinned makepad into small Rust harnesses and compile them with rustc. The pin moved and the stubs did not: `set_text` now ends with `check_text_is_empty(cx, Animate::Yes)`, and the `ShowTextIME` arm clears `self.os.pending_ime_hide`, so both harnesses failed to compile wherever the pinned sources are checked out (GitHub's runner has none, so the tests skipped there and the failure went unseen). The editor-sync harness gains an `Animate` enum and the two-argument stub; the IME-visibility harness gains the `pending_ime_hide` field and checks that a show cancels a pending hide, as the real arm does. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ymote
force-pushed
the
fix/ime-handoff-test-stubs
branch
from
October 11, 2026 05:57
c44f829 to
284af8f
Compare
Contributor
Author
|
Local CI passed on 284af8f ( GitHub would run for this PR: rom.yml. Merged on this local pass (macOS runner queue); GitHub CI runs on the merge commit on main.
Notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two
rom/tests/test_android_ime_handoff.pytests splice methods from the pinned makepad (d653bc44) into small Rust harnesses and compile them withrustc. The pin moved and the stubs did not:TextInput::set_textnow ends withcheck_text_is_empty(cx, Animate::Yes); the harness stub took one argument and had noAnimate.ShowTextIMEarm clearsself.os.pending_ime_hide; the harness'sOshad no such field.So
test_real_editor_setters_sync_once_before_later_inputandtest_real_android_dispatch_revalidates_keyboard_dismissalfailed to compile wherever the pinned sources are checked out (.sources/), which is every local CI run ofrom.yml's product job. GitHub's runner has no such checkout, so the tests skip there and the failure went unseen.The editor-sync harness gains an
Animateenum and the two-argument stub; the IME-visibility harness gains thepending_ime_hidefield and now also checks that a show cancels a pending hide, as the real arm does. No change to the shell or the phone.Checks
python3 -m unittest tests.test_android_ime_handoff -vfromrom/with JDK 17 on PATH and the pinned sources present: 6/6 pass (before: 2 errors).python3 -m unittest discover -s testsfromrom/: 101 tests, OK.tools/ci-local.sh --only romon c44f829 (Mac, JDK 17, node 24, Android SDK on PATH): 10 passed, 0 failed, 0 skipped, including the product job'sunittest discover.Found while gating #477, whose local Mac run fails on this step until it lands.
🤖 Generated with Claude Code