Repository navigation
Maps: render driving tiles and 3D buildings above host backgrounds - #435
Merged
Merged
Conversation
…ings Both drive maps read makepad's hosted world map (makepad.nl), as the browse map does, instead of building tiles on the phone from Overpass. The 3D drive map sets buildings_3d, so buildings get walls and roofs when the camera tilts. maps.mail.ru, which only the drive tiles used, leaves the manifest; the three Overpass mirrors stay for place details.
guofoo
force-pushed
the
feat/maps-3d-buildings
branch
from
October 19, 2026 06:23
ef2c648 to
e5c948e
Compare
ymote
added a commit
that referenced
this pull request
Oct 21, 2026
main gained a 38th stacked runtime patch (makepad-map-texture-depth, #435). Finance's patch is now the 39th, after it; the overlay tree moves e7560180 -> dafa5734 (only apps/finance changes; cross-checked with an independent replay). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ymote
added a commit
that referenced
this pull request
Oct 21, 2026
Main's lock now stacks makepad-map-texture-depth.patch as the 38th patch (#435). The Android buffer-stuffing patch follows it as the 39th, unchanged (sha 7f87b527); it touches no file the map patch does. The makepad tree, replayed over the whole stack with git apply --index, is fcd2a327. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maps driving now uses the pre-baked world archive and renders visible 3D buildings. This also fixes the macOS symptom where only street names and the route appeared over a blank map, even after every visible tile had loaded.
Follows #395 (merged).
Changes
https://makepad.nl/maps/world-20260926.mkmap, matching the browse map. Only the 3D view enablesbuildings_3d.CachedViewwith its own depth buffer. Tilted geometry previously failed the depth test against the enclosing host background; labels and route used ordinary UI ordering and remained visible. The isolated map texture composites below the navigation controls while preserving depth testing between buildings and terrain.texture_depthproperty, including cache invalidation when the property changes. Other cached views retain their default behavior. The overlay hash and resulting runtime tree are locked.maps.mail.ruhost; retain Overpass mirrors for place details. Update English and Chinese app documentation.Latest validation on
b188ddd1(2026-10-21)Merged main
45edea31into this branch and resolvedruntime-patches.lock.jsonby retaining both main's Apple UI font overlay and the Maps depth-buffer overlay. Reapplied every locked patch to a fresh temporary index; the independently generated tree matches the applied runtime (e756018052209a8159ae5ba6d3a66dba8e04d4c0).mobile-apps, Home withmobile-apps, both packaging dependency-graph checks, setup/Cargo validation and generated native-app checks: passed. Existing dependency warnings remain.Earlier validation on
b5398d1e(2026-10-21)cargo build --locked --release -p octosense --no-default-features --features app-hub,dev-mode: passed.phone/,cargo test --locked --features mobile-apps -p octosense-shell: 1,290 passed, including 42 Maps tests. Used isolated OctoSense/Makepad/Rinx data and hidden windows. The initial outer-sandbox run blocked five macOS sandbox/socket tests; the unrestricted rerun passed all tests. Optional real-kernel paths were not exercised.mobile-apps, and Home withmobile-apps: passed. Both packaging dependency-graph checks passed.python3 tools/setup.py --check --cargo,python3 tools/native_apps.py --check, and whitespace checks passed. Existing dependency warnings remain.Earlier device evidence
Pixel 7 Pro testing on
ef2c6483, before the October 19 rebase and this depth-buffer fix, showed 3D buildings and map fill within about 20 seconds; first opening 2D took about 5 seconds. That evidence has not been repeated on this head. The depth-buffer fix is verified on macOS only; Android, iOS and OpenHarmony rendering on this head remain unverified.The camera retains its existing orthographic tilt and navigation behavior.