Repository navigation
Conversation
ymote
force-pushed
the
fix/wasm-invocation-isolation
branch
from
October 8, 2026 04:51
eb16fe9 to
43bad66
Compare
Contributor
Author
|
Implemented on main through #370, merged as The final |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Splash tool that forwards a native
host.requestresponse unchanged can fail withinvalid_result: unknown JSON key: Makepad createdis_ok,dataanderrorLiveIds without registering their string names. Explicit field reconstruction happened to intern those names, hiding the failure. Register the six static envelope keys at creation, including immediate capability refusals; leave the bounded JSON converter unchanged.Add a fresh-process regression for success, native error and capability refusal, plus a reproducible signed Android fixture that forwards complete Wasm responses. The OnePlus 6 passed 22/22 checks from clean source
e67ce63ebca6054961899691e1644a54c2b4f081, runtime tree0fc8e29e2411fd7eb94d845ba16a261d2ebc9dfc; the checked-in receipt includes APK and source hashes. Its guest intentionally retains input if reused, so the checks also exercise fresh instances after success, guest error, trap and deadline through real app-tool dispatch. No personal account or model was used; the isolated package was stopped afterward.Validation:
splash_hosttests passed, including the fresh-child success/error/refusal test and existing cyclic/oversized JSON protections.This PR is stacked on #367 so its exact-head local CI remains unchanged. Earlier 19/19 explicit-field evidence did not validate raw forwarding; the repaired private run passed 20/20, and the public reproducible harness adds two compiled-identity checks. The receipt-only follow-up commit preserves the exact compiled source revision.
Listing-image follow-up: replaced the unrelated permission-lab screenshot with an actual hidden native macOS capture after this fixture’s signed Wasm tool completed (source
d3535a95). The fixture digest was refreshed and unsigned development admission passed. This later image-only revision does not alter or extend the original OnePlus receipt.