Repository navigation
Conversation
card_runner_restyle_keeps_dynamic_labels_wrapped_and_explicit_no_wrap uses octosense_appstore (an app-hub optional dependency) and selected_glance_style_reaches_existing_cards_without_replacing_state calls tile_cx, which is cfg(feature = "app-hub") -- so a no-default-features lib test build of octosense-shell (the --linux-host sandbox:: check) has not compiled since #357. Both tests now carry the gate their helpers already have; with --features mobile-apps they run and pass as before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ymote
force-pushed
the
fix/app-hub-cfg-test-gates
branch
from
October 8, 2026 02:44
fd86977 to
57f14d1
Compare
Contributor
Author
|
Superseded: #362's dc8cf36 ("Gate App Hub rendering tests on their optional dependency") landed the identical two app-hub gates while this PR's gate run was in flight — main already compiles the no-default-features sandbox:: build, so --linux-host is restored without this. Local evidence from this branch still holds (full ci-local PASSED in 40m04s on 57f14d1, plus the targeted proofs in the description). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
--linux-hostsandbox check compile failure octosense-org-cd hit on main during #364's gate: since #357, a no-default-features lib-test build ofoctosense-shellfails —module_resize_tests.rs:525usesoctosense_appstore(anapp-huboptional dep) andglance_card.rs:1474callstile_cx, which iscfg(feature = "app-hub"). Both new tests now carry the same gate their helpers already have.Verified:
cargo test -p octosense-shell --lib sandbox:: --no-default-features --no-run— compiles (failed with the two E04xx before).phone/,--features mobile-apps: both tests still run and pass (1 passedeach).Hold: not to be merged until octosense-org-cd's #364 gate completes — main is frozen by agreement. After that, this unblocks
--linux-hostfor everyone.🤖 Generated with Claude Code