Repository navigation
Unify app interfaces and fix Android editor and camera startup - #355
Merged
Merged
Conversation
ymote
marked this pull request as ready for review
October 7, 2026 08:06
ymote
force-pushed
the
feat/octoscript-app-ux
branch
from
October 7, 2026 08:06
8e6438f to
044fe1d
Compare
ymote
force-pushed
the
feat/octoscript-app-ux
branch
from
October 7, 2026 08:46
d1549ff to
ee82715
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OctoScript system apps now share responsive, theme-aware surfaces, readable secondary text, larger actions and bounded desktop content. Calendar editing remains reachable above the Android keyboard, map tiles follow appearance changes, Glance chat has more readable spacing, and the native App Hub pin includes the matching navigation refresh. News follows an in-flight fetch without starting duplicate work.
A first Camera permission dialog previously changed an unprepared video into a false Playing state. The recorded runtime overlay preserves lifecycle state and waits for a single permission result before opening the camera. Video now preserves aspect ratio in Fill layouts using the resolved drawable size. Android provider QR scanning chooses supported Camera2 preview/YUV buffers, fits the visible preview proportionally, and retires callbacks before closing its surface so cancellation and reopening stay safe.
Validation:
Camera follow-up validation:
Acceptance remains open: a clear-scene visual comparison on the phone is pending because the current camera view is dark/too close. QR decoding/provider import was not exercised. Android video recording is unimplemented. No 95/100 pass is claimed. Review is by the author, not an independent reviewer; raw pixel diagnostics are retained separately from the UX rubric. iOS/OHOS, assistive input, live email/model execution, map routing and video capture/playback remain unverified.
Companion: OctoSense-org/OctoSense-App-Hub#128 (merged; pinned f762267, including the host-sheet and key handling fixes already on main). Original device captures and private logs remain local; reproducible harnesses and bilingual instructions are in tools/app-ux/.
Runtime fixes: OctoSense-org/makepad#103. The recorded patches apply the same changes until the runtime pin is advanced.
Merge preparation: rebased onto main 1bc777a. The runtime lock now contains both the host authentication WebView overlay and the camera overlays; each patch applies cleanly and the computed runtime tree matches the lock. The three camera patch files and the tested Camera/AI providers app sources are unchanged by the rebase. Makepad #103 and App Hub #128 are merged. The Photos logic-test harness now starts after the host widget prelude; all 14 existing Photos memories tests pass locally. App Hub pins now target the merged revision f762267, preserving main's host fixes and published contract 1.5.0 while adding the UI refresh. Runtime graph, generated native-app configuration and shared interface checks pass. Full GitHub CI passed on head ee82715: desktop, home, apps, services and kernel-security. Main 1bc777a also has passing Desktop, Phone and Apps and services workflows.
Final CI: Desktop, Phone, Apps and services.