Repository navigation
Add shared OAuth services and connected App Hub app hosting - #347
Merged
Merged
Conversation
This was referenced Oct 6, 2026
ymote
marked this pull request as ready for review
October 7, 2026 00:32
ymote
force-pushed
the
feat/app-hub-connected-samples
branch
from
October 7, 2026 00:44
26b9fe9 to
4109d59
Compare
Preserve the connected OAuth services, native Markdown editor, App Hub catalog compatibility pin, and macOS Select All fix while merging main 2baa5c1. Keep the desktop approval provenance and Android Enter overlays on the newer Makepad base; drop overlays already merged upstream.
Contributor
Author
|
Local CI passed on 84e3438 ( GitHub would run for this PR: desktop.yml, phone.yml, apps.yml, rom.yml. Merged on this local pass (macOS runner queue); GitHub CI runs on the merge commit on main.
Notes:
|
Contributor
Author
|
Merge-gate note: GitHub refused the unified diff because it exceeds its 20,000-line limit. The repository merge helper was run with only its changed-file inventory call adapted to the paginated pull-request files API. The returned file count was checked against the PR metadata, with no duplicates. The helper's exact-head, clean-tree, workflow coverage, no-skip/no-failure, current-main ancestry and red-main checks all passed unchanged. All 45 local CI steps passed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary App Hub apps can reuse host-owned GitHub/Google authorization and their declared tools against shared provider services. This supports GitHub Notes, Inbox Assistant and Google Calendar without introducing an OctoSense account. Existing system Mail and Calendar remain available.
The host owns credentials, scopes, account selection and revocation. Provider operations retain the calling app/account. Inbox completes durable incoming-mail events only after a consented peer records a quiet decision or persists a bound card. Failed turns release their lease and back off. Protected writes retain native review; model and remote inputs cannot approve sending.
Installed apps publish admitted Glance templates and reopen their originating app/event. Foreground workspaces retain drafts and own host review sheets. Modal review draws exclusively in its host isolate, preventing the underlying editor text from being batched above it, while preserving the resident app VM. Cancellation, collapse and cold restoration retain the original request and unsent draft. Notes now uses Rinx’s article writer layout: an icon header, desktop source/split/preview, phone bottom formatting, styles and native table picker. Its file caption and publish-position icon retain GitHub semantics. Failed draft loads cannot expose a blank editor that overwrites the retained note. Floating shell navigation hides throughout native IME display and returns at its prior dock. Android multiline Enter now finishes composition before inserting a newline, preserving the last word; ordinary soft-IME replacement is unchanged. ADR 0010 and bilingual guides document the boundaries.
Dependencies
d6a14133527d803a26032550d50427c17d126ca4, which preserves legacy catalog parsing and accurately discloses network access through host services. Its full core suite passed 207 tests and the published-contract semver check passed 202 checks.Validation
Final head
84e3438b7ee25b43ba945bfe063db594a71e61baincludes current main and its Makepad/octos pins. Complete local CI passed on this exact clean head: all 45 steps across desktop, phone, apps and ROM, with no skipped or failed steps (44m 45s). This includes 959 shell tests, real-kernel two-lane/security checks, connected accounts, the Rinx editor, AppCard, ROM product tests and browser installer checks. The run used macOS; Linux-only behavior is covered separately by the successful GitHub services/kernel-security jobs. GitHub desktop, apps/services and ROM workflows also passed; its Home workflow was still building when the local run completed.The normal production macOS package from this exact source passed the official signed Store journey for all three previews: Search → Get → permission review → Install → Open, local editing, and exact draft restoration after a full restart. Nine functional checks and six independently reviewed visual gates passed, including real Command-A replacement. The original captures and hashes are in App Hub #126. Fourteen read-only capture errors and one driver stop/resume are retained; there were zero input errors or uncertain input replays. This is not a clean instrumentation soak or live provider acceptance.
The app, kernel, ZIP, mounted DMG and evidence archive passed privacy scans. ZIP and mounted DMG match all 416 packaged files, with source-bound licensing notices included. The preview is not Developer ID signed or notarized.
Earlier focused and device evidence below remains bound to its recorded source; it is separate from the final production Store check.
48 OAuth tests and the explicitly run macOS vault test passed earlier. After the final editor and IME navigation changes, 956 shell tests, desktop checks with/without mobile apps, Home checks and both dependency graphs passed. The reusable editor also passed 3 unit tests and both wide/narrow native writer journeys. The later Java-only Enter patch passed 96 ROM tests, 18 setup tests, fixed-source/stack validation and native-app generation. Its regression reproduces the lost composing word before the fix and passes afterward.
Strict signed private-catalog install/reopen/tamper refusal passed for all three current bundles, including the changed Inbox digest. Hidden native Makepad acceptance uses actual installed apps and host services with synthetic provider HTTP/vault dependencies:
Original images were inspected independently from state assertions. Reproduction scripts, bilingual docs and allowlisted receipts retain failures and exact source/binary hashes. Changed-file privacy, syntax, links and diff checks passed. Measurements are instrument round trips, not FPS or physical display latency.
Preview limits
Memory increased in the finite soaks (Notes and Calendar provider hosts; Inbox full Shell); long-term stability remains unproven. The two Makepad frame-submission errors remain unresolved.
Live provider sign-in/read/write/send requires registered clients and user consent; none is claimed. Physical Gmail approval and MiniMax remain unverified. Android shared Google authorization still needs its native adapter; background lifecycle is unverified. Linux protocol/build checks passed but its native vault was unavailable/locked and no GUI was available. Windows cross-compilation was blocked by absent Windows SDK headers; native Windows execution and protected Gmail sending on Windows/Linux are unverified. No numeric UX or release score is claimed.