Repository navigation
Phone: Calculator, Clock, Notes, Reminders and Weather ship in Home - #329
Merged
Merged
Conversation
Switches the desk to that phone shell before the other test actions, so a later launch-<app id> opens an app at a phone's size on a desktop: an app's phone layout, checked over --remote (/g, /snap) without a device. shade: and page: switched style as a side effect of something else; this one only switches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The five Makepad apps that became native apps in #309 were desktop only. Their native-apps.json entries now link them into the phone shell by default as well (shells.phone "default"), like Rinx and App Hub: in-process modules, each with its own agent and its read tools for the system agent. On a Redmi Note 12 (Android 15), Calculator laid its keypad out for the phone and then lost it: the phone shell's style reapply after a hosted module's first frame wrote the DSL's key sizes back, and Calculator skipped the layout it thought it had applied. makepad #99 makes it lay out again after every apply; until the next makepad move it is a stacked runtime patch (makepad-calculator-restyle, tree 47a8b47d). The phone and desktop READMEs name the apps on the phone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Local CI passed on 2af498e ( GitHub would run for this PR: desktop.yml, phone.yml, apps.yml. Merged on this local pass (macOS runner queue); GitHub CI runs on the merge commit on main.
Notes:
|
This was referenced Oct 5, 2026
ymote
added a commit
that referenced
this pull request
Oct 5, 2026
Five reviewers audited every file under docs/ against the code at 89e6c42. Each finding was confirmed in the code, git log or gh before it was applied. A final review of this diff found 11 more problems, which are fixed. - Native agents (#309, #329, #330): ai-services, architecture and the walkthrough now describe: - the five Makepad apps' agents, through OctosPeer and serve_tools with no workspace, and their system_tools; - the Terminal's own_tools; - native peers living with the open window. They no longer say that Rinx is the only native agent or that nothing uses the peer link. - terminal.run exists only while the Terminal runs as its own sandboxed process. Release packages ship no process-app binary, so there the Terminal runs in-process and Task is absent. Task is named as a process app. - Admitted AGENT.md and skill text go with every turn. Mail has eight tools and an incoming-mail trigger. agents.provision and agents.status accept only os.mail. - Smaller fixes: keys on Windows, the window-manager override path, phone glance cards, unsandboxed catalog apps, octos_peer frame names, TurnFrom (Person), the default build's octos-core, the packaged kernel, the octos child's runtime, and local-ci's merge scope, clone lock and rom.yml paths. - ADRs get dated notes: 0002 is partly implemented; 0004 has three plan items open and notes on Task, the Terminal's agent, host tools and #238; 0005 has notes on app-contract 1.1.0; Home 0001 and 0002 get notes. The ADR index statuses are updated, and the Photos and icons plans are marked done. - Chinese parity: mail-agent-events regains its sequence diagram. ai-services, architecture, the walkthrough and the mail-events report regain their missing rows and details. - <app> written outside code is escaped (GitHub stripped it). ai-services-processes.png and ai-services-cross-app-call.png show the shipped peer link and peer/input as solid, and mark the mail.send hop as planned. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five Makepad apps that became native apps in #309 were desktop only. They now ship in the phone shell by default too, like Rinx and App Hub: in-process modules, each with its own agent, and their read tools for the system agent.
Commits
style:<android|ios>test action. It switches the desk to that phone shell before the other test actions, so a laterlaunch-<app id>opens the app at a phone's size on a desktop: an app's phone layout, checked over--remotewithout a device.shade:andpage:switched style only as a side effect.native-apps.jsonsetsshells.phoneto"default"for them.tools/native_apps.pyadds their features to Home's default andmobile-appsfeature sets. The READMEs (phone and desktop, EN/zh-CN) name the apps on the phone.A Calculator fix, carried as a runtime patch
On the phone, Calculator's keypad overflowed: three rows showed, and the operator column was cut off. Calculator had computed the compact layout for exactly the phone's size (392.7 × 791.3 points, measured on the device). Then the phone shell's style reapply after the module's first frame wrote the DSL's 85-point keys back. Calculator skipped re-laying out, because it had cached its last layout.
makepad #99 (open) makes it lay out again after every apply. Until the next makepad move it's a stacked runtime patch:
tools/runtime-patches/makepad-calculator-restyle.patch, combined tree47a8b47d. The tree was computed by applying the stack in a throwaway index; the same method reproduces the previous tree7e7a9c13.Checks
dev.makepad.octosense.nativeapps, the installed Home untouched). Each app was launched withAPP_CONFIGtest_actionsand screenshotted:python3 tools/native_apps.py --checkandpython3 tools/setup.py --check --cargo: pass. Tools tests: OK.cargo test --locked -p octosense-shell: 802 passed. Fromphone/,cargo test --locked --features mobile-apps -p octosense-shell: 869 passed.🤖 Generated with Claude Code