Repository navigation
Pin App Hub 0d5b47a2 and octosense-app-contract 1.1.0 - #312
Merged
Merged
Conversation
App Hub moves from 58c3c8ae to its main 0d5b47a2: - #53: publisher keys come from the authenticated catalog. - #54: an installed release launches as itself, from verified bytes. - #63, #64: the native apps OctoSense made native are reserved (calculator, clock, notes, reminders, weather, browser, task); its example app `weather` became `forecast`. - #61, #67: makepad repins (this workspace's [patch] wins either way). - Docs. octosense-app-contract 1.1.0 (App Hub #66, published to crates.io) carries the reserved names. app-policy re-exports them, so App Hub's admission tests at 58c3c8ae, whose fixtures still use `weather`, fail against 1.1.0. The pin and the lock move together. App Hub's new bundle layout (App Hub #62, which #301 prepares for) is not in 0d5b47a2: installed bundles stay where the shell looks today. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Local CI passed on 41228a7 ( GitHub would run for this PR: desktop.yml, phone.yml, apps.yml. Merged on this local pass (macOS runner queue); GitHub CI runs on the merge commit on main.
Notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App Hub moves from 58c3c8ae to its main 0d5b47a2, and
octosense-app-contractfrom 1.0.0 to 1.1.0 (crates.io, App Hub #66).Why together
1.1.0 reserves the ids of the Makepad apps OctoSense makes native: calculator, clock, notes, reminders, weather, browser and task (App Hub #63, #64).
octosense-app-policyre-exportsRESERVED_NAMESfrom it.The App Hub admission tests at 58c3c8ae still use an example app named
weather, so with 1.1.0 they fail ("app id "weather" is reserved"). The phone workflow's "Test Home, App Hub admission and runtime policy" step runs those tests (found by #309's local CI). App Hub's main renamed that fixture toforecast. So the pin and the lock move in one change.What App Hub 0d5b47a2 brings
.runningdirectory before launch.[patch]wins.App Hub's new bundle layout (App Hub #62, which #301 prepares the shell for) is not in 0d5b47a2. Installed bundles stay where the shell looks today.
What moves
Cargo.toml: the four App Hub crates.native-apps.json: theapphubentry's revision.tools/native_apps.pyhas nothing to regenerate.Cargo.lock: the App Hub sources andoctosense-app-contract 1.1.0.crates/ai-host/README.md: the pin it names.Checks
python3 tools/native_apps.py --checkandpython3 tools/setup.py --check --cargo: pass.phone/, the phone workflow's test step:cargo test --locked --features mobile-apps -p octosense-shell -p octosense-home -p octosense-app-policy -p octosense-app-hub -p octosense-appcard -p octosense-ai-host: 1194 passed, 0 failed, in 19 test binaries.cargo check --locked -p octosense: passes.🤖 Generated with Claude Code