Repository navigation
Glance: a press on a card's chip in the panel no longer opens the card window - #299
Merged
Merged
Conversation
The supervisor saw the kernel end (its stdout closing, or its exit status) and read the stderr tail at once, but stderr is copied into the tail by a task of its own. The line the kernel wrote just before it exited could still be in the pipe, so the reason lost it: CI's `a_kernel_that_dies_closes_its_connections_with_its_last_words` failed with "the kernel closed its output: fake kernel up", without the "asked to exit" the fake kernel wrote last. The tail is now read after the kernel is stopped and the stderr task has reached the end of the pipe (bounded at 2 s, for a process the kernel started that still holds the pipe). Failed reasons get the same complete tail. The test asks for the last words themselves, not just "exit". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… probes The glance tile tests register probe system apps (os.glancetile, os.glanceinput, os.glancequiet, os.glancesweep) in App Hub's system-app registry. That registry is process-wide, has no removal, and is the one `system_card_apps` lists, so a catalog test running after a glance test in the same process saw the probes as launcher rows: `bundled_apps_open_without_catalog_files_or_child_processes` failed its catalog comparison 7 of 10 times beside `glance_card::` on main, and `the_system_apps_ship_as_card_apps` compares the same list. Tests now register their system apps through `apps::test_system_apps::register`, which notes the id before it registers it, and the tests of the build's own catalog leave noted ids out. Production code is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`approvals::tests::the_relay_gets_decisions_made_before_it_was_installed` began with `init_memory()`, which replaces the shell's process-wide approvals with empty ones. Every consent a test running beside it had given was gone. `app_chat::tests::the_panel_opens_a_sharing_context_and_sends_person_turns_there` allows its app, then reads `agents::line()`, which reports a peer slug only while the app is allowed. Beside `approvals::` it failed 50 of 50 runs with `peer_slug: null`. The same test also installed its recording relay into the shared approvals, where it would take other tests' decisions. The relay seam (`approval_requested`, `set_relay`, `bus_requested`) is now methods on `Approvals`. The free functions call them on the shell's approvals, as before. The test builds `Approvals::memory()` and never touches the shared one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the whole connect's `a_jail_only_app_reads_its_jail_and_is_refused_everything_else` failed on GitHub's macOS 14 runners with "the hub is reachable: " and nothing after it: the sandboxed `nc -z` exited 1 without a word, because nc prints why a connect failed only with `-v`. Its exit status says only that the connect did not complete. A sandbox refusal and a refusal past the sandbox (no listener on the port then, the network stack) look the same, though only the first is what this test is about. Closing the hub's listener before the probe reproduces the CI message exactly. The probe now runs `nc -v -n` and the test reads what nc says. The hub fails only on the sandbox's own refusal (EPERM from Seatbelt and seccomp, EACCES from Landlock), or when nc never reported a connect at all. A refusal past the sandbox is printed and passes. Any other port must now be refused by the sandbox itself, not just fail, which the old check could not tell apart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
octos#2675 makes session/hydrate rows name their tool calls: a tool row carries tool_call_id and tool_name, an assistant row its tool_calls. The shell's system chat and "Ask <app>" panel already read tool_call_id and name/tool_name, and the broker's merged history passes rows through, so reloaded tool rows now show their tool's name instead of "tool". The two-lane scenario checks it against the real kernel: News's agent's news_share call in the panel's reloaded history, and the system chat's peer_send_input. The pin also brings #2261, #2664, #2665, #2669, #2671 and #2672. octos-core, octos-cli, octos-research and the kernel artifact move together; Cargo.lock changes only the 17 octos source lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…w behind it A module tile claimed presses but never a hover. A mouse move over a part of a card window that takes no hover (Mail's empty page) went on to the tile behind unclaimed, and the app there took it: a News button under Mail lit up and showed its hand cursor. A tile behind also handed its app every move, claimed or not, as it handed presses before #277. The live tile now treats a hover (a mouse move with no button held) the way #277 treats a press. A hover inside it that none of its app's widgets took is the tile's, and one a window in front already took is let by, so its app never sees it. The one exception is the move that leaves a widget of the app still holding the hover: it reaches the root, so that widget sees its hover end, and being claimed it lets no other hover start. The closed face of a stopped app claims a hover inside it too. Moves with a button held (drags) pass as before, so captures keep working. Tests, in module_input_tests.rs: a hover on the window in front never reaches the app behind; makepad's Button behind it never lights up or shows its hand; a hover on a stopped face never reaches the app behind it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ot at its top left The closed face draws its line and Restart button centred, but it kept the rect `walk_turtle` returned for the button as Restart's hit rect. The face's turtle centres its content when it ends, which moves the drawn button after it was walked, so the kept rect stayed at the face's top left. A press on the visible button only raised the window, and a press at the top left, where nothing is drawn, restarted the app. The face now hit-tests Restart by the button's drawn area, as any widget is hit-tested: clipped, at the time of the press. It keeps no rect of its own. Tests, in module_input_tests.rs: Restart responds where it is drawn (a click and a tap on the visible button restart the app, a press at the top left only raises the window), and #277's stopped-face test now presses the drawn Restart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e card window Since #290 a press on a card in the glance panel that the card's own controls do not claim opens the card in the card window on its release (pointer_claimed_area across the tiles' dispatch). A field claims its press, but a chip does not: an L0 card's tap targets are OctoscriptTap, which never calls event.hits (so a list can still scroll under it) and fires on the release. So every press on Reply, Ask, Track or Send opened the card window and closed the panel, and the chip's tap ran in the panel's session as the panel forgot it: the card's buttons and its in-card chat could not be used in the panel. - glance_panel.rs: a press released on its card opens the card window a frame later, unless the card clicked by then. A tap target calls its card once the release's handlers have run, and the click is seen before the card's taps run, on any event after the release's. - glance_card.rs: has_clicks, whether an isolate has a click waiting (a NAV call with no text; a field's carries what was typed). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ymote
force-pushed
the
fix/glance-chip-opens-card-window
branch
from
October 2, 2026 20:59
e1f3c97 to
fcc0610
Compare
This was referenced Oct 2, 2026
Merged
Contributor
Author
|
Merged in a merge train; local CI (Mac with rom toolchain + --linux-host) passed on the train head 72e5d55, which contains this PR.
The train was #291, #293, #297, #294, #298, #295, #296, #299, #300 and #292, on main f6678b5. After the last merge, main 301be0c has the tested head's tree. |
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while verifying the follow-up for a tall chat card in the glance panel. Since #290, a press on a card's chip in the glance panel (Reply, Ask, Track, Send…) opens the card in the card window and closes the panel. So a card's buttons and its in-card chat cannot be used in the panel. The fix keeps #290's rule as written: "a press on a card outside its own controls opens it in the card window".
What was wrong
#290 opens the card window on the release of a press that the card's own controls do not claim (
pointer_claimed_areaacross the tiles' dispatch). A field (TextInput) claims its press. A chip does not: an L0 card's tap targets are Octoscript-Makepad'sOctoscriptTap, which never callsevent.hits(so a list can still scroll under a full-width row) and fires on the release. Every press on a chip therefore counted as a press "on the card". The chip's tap still ran in the panel's session, but by then the panel had closed and dropped that session, and the card window showed the card from the start.Seen on
main(8e65d5c6, headless, below), from one press on Reply:glance panel: os.mail/ana-contract tap reply,wm: glance card os.mail/ana-contract opens in the card window,wm: glance panel closed.The fix
glance_panel.rs: a press released on its card no longer opens the card window at once. It opens it one frame later, unless the card has clicked by then. A tap target calls its card once the release's handlers have run (makepad runs a widget's script call at the end of the event's cycle). The panel looks for that click on every event after the release, before the card's taps run. So a chip's press stays the chip's, a field's press is claimed as before, and a press on the card's text or face opens the card window, a frame later.glance_card.rs:has_clicks(heap), whether an isolate has a click waiting (aNAVcall with no text; a field's carries what was typed).Tests
On the Linux build host, at this PR's head (
e1f3c979, onmainat8e65d5c6), with its own target dir andCARGO_BUILD_JOBS=12:phone/:cargo test --locked --features mobile-apps -p octosense-shell glancephone/:... -p octosense-shell mobile;... phonephone/:OCTOS_SHELL_TEST_KERNEL=<octos ae230ce0> cargo test --locked --features mobile-apps -p octosense-shellphone/:OCTOS_SCENARIO_TEST_KERNEL=<octos ae230ce0> ... --lib host_tools::scenario_tests -- --test-threads=1cargo test --locked -p octosense-l0-chat; its clippy with-D warningscargo check --locked -p octosense(and--features mobile-apps); fromphone/:cargo check --locked -p octosense-home --features mobile-apps;python3 tools/setup.py --check --cargotools/ci-local.shwas not run.New test:
glance_card::tests::a_waiting_click_is_seen_without_taking_it. The panel's release, frame and click sequence is covered by the instrument run below.Instrument check (headless)
The release desktop shell ran on the Linux host under a headless weston (
--backend=headless --renderer=pixman), driven through makepad's remote instrument withOCTOSENSE_GLANCE_DEMO=mail: two fake Mail cards, no mail read and no model called. Its default style was used (light), and the demo cards open the glance panel. Frames come fromMAKEPAD_WRITE_FRAMEBUFFER_PNG. Chips were found by colour inside the tiles that the panel logs.main(8e65d5c6): a press on Reply in the panel logstap reply, thenopens in the card windowandglance panel closed. The card window shows the card's briefopens in the card window,glance sheet: opened), and Esc closes itNot covered
🤖 Generated with Claude Code