Repository navigation
docs(ai-services): contained apps' assistant is behind consent, not off - #268
Merged
Merged
Conversation
docs/ai-services.md and its Chinese twin still described the contained apps' octos service as it was before #184: - the gate is off by default and needs OCTOSENSE_CONTAINED_APPS=1; the code's default is first-use consent (contained_gate_from), with 1 the developer override that asks nobody and 0 off; - a contained peer's tool approvals are declined; the broker hands them to the shell's approval router, and only a host without one declines; - octos.turn.start takes only text; it also takes trigger and from; - nothing in the shells runs an app's agent; since #184 an app that declares one, declares octos.*, or ships tools.json gets a prepared peer with its tools and the "Ask <app>" panel; - the News bundle does not declare `news` yet; it does, and reads from it when host.has("news").
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the English/Chinese AI-services guides to describe first-use consent as the default for contained app agents. An unset OCTOSENSE_CONTAINED_APPS asks for consent, 1 skips that first-use check, and 0 disables the contained octos service; tool approval rules remain separate.
Use a three-state table for consent and separate call arguments, approval routing and reply limits. Distinguish the broker app identifier from the kernel-issued peer slug. Reconcile stale status rows with implemented tools, peers and human conversations, while identifying prompt loading, skills and automatic triggers as remaining work. Use the repository’s kernel build helper instead of a hardcoded revision in the launch recipe.
Validation for this writing revision: source review, relative links and heading anchors, English/Chinese consistency, whitespace and the kernel helper’s planning mode. Build, GUI, provider and device execution remain unverified. No runtime code changed.
This PR overlaps #275 in both AI-services guides. Their shared explanations have been aligned, but reconcile the overlapping branches before merging. Both remain open.
Writing assessment after parallel revision and a separate review: 4.5/5 (A−), considering beginner orientation, terminology, worked examples, organization and bilingual consistency. This is our assessment, not an external approval.