Skip to content

ADR 0005: review fixes (pending items, plan status) - #250

Merged
ymote merged 2 commits into
mainfrom
docs/adr-0005-review-fixes
Oct 1, 2026
Merged

ymote merged 2 commits into
mainfrom
docs/adr-0005-review-fixes

Conversation

@ymote

@ymote ymote commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #240, from robrix-hagency-87's review. Docs only:

  • §3: the root Cargo.toml says "1"; Cargo.lock records the exact version (1.0.0).
  • §3: the lowest/highest 1.x build in Rinx CI is marked pending (only 1.0.0 is published).
  • §5: the two-reviewer rule is marked not yet enforced (App Hub has no CODEOWNERS).
  • Plan: steps 1–4 done with their PRs; step 5 open.

🤖 Generated with Claude Code

ymote and others added 2 commits October 1, 2026 00:52
…pins the version [skip ci]

- §3: the root Cargo.toml says "1"; Cargo.lock records the exact version.
- §3: the lowest/highest 1.x build in Rinx CI is pending until a 1.1.0 exists.
- §5: the two-reviewer rule is not enforced yet (App Hub has no CODEOWNERS).
- Plan: steps 1–4 done with their PRs, step 5 open.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ymote

ymote commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Local CI passed on dd45e04 (tools/ci-local.sh --only rom, 0s, Darwin arm64).

GitHub would run for this PR: none. Merged on this local pass (macOS runner queue); GitHub CI runs on the merge commit on main.

Job Step Result Time
ci-local / drift The local mapping fits the workflows PASS -
rom.yml / product python3 -m unittest discover -s tests -v SKIPPED (!) -
rom.yml / product Check generated Agent Binder client SKIPPED (!) -
rom.yml / product bash -n scripts/stage-forks.sh scripts/publish-release.sh scripts/apply-to-tree.sh scripts/build-rom.sh PASS -
rom.yml / web-installer npm ci --ignore-scripts --no-audit --no-fund SKIPPED (!) -
rom.yml / web-installer npm test SKIPPED (!) -
rom.yml / web-installer npx playwright install --with-deps chromium SKIPPED (!) -
rom.yml / web-installer npm run test:browser SKIPPED (!) -
rom.yml / web-installer python3 -m unittest discover -s tests -p test_installer_manifest.py -v SKIPPED (!) -
rom.yml / web-installer bash -n scripts/release.sh SKIPPED (!) -

Skipped (these did NOT pass; (!) marks a skip that blocks tools/ci-local-merge.sh):

  • rom.yml / product: python3 -m unittest discover -s tests -v: javac -version does not work here: install a JDK (17 or newer) and put its bin/ on PATH or set JAVA_HOME
  • rom.yml / product: Check generated Agent Binder client: needs build-tools/35.0.0/aidl, platforms/android-35/framework.aidl in the Android SDK (~/Library/Android/sdk): install the SDK packages 'build-tools;35.0.0' and 'platforms;android-35' (sdkmanager) and set ANDROID_HOME
  • rom.yml / web-installer: npm ci --ignore-scripts --no-audit --no-fund: no node, npm, npx on PATH (the workflow uses node 24); put node on PATH
  • rom.yml / web-installer: npm test: no node, npm, npx on PATH (the workflow uses node 24); put node on PATH
  • rom.yml / web-installer: npx playwright install --with-deps chromium: no node, npm, npx on PATH (the workflow uses node 24); put node on PATH
  • rom.yml / web-installer: npm run test:browser: no node, npm, npx on PATH (the workflow uses node 24); put node on PATH
  • rom.yml / web-installer: python3 -m unittest discover -s tests -p test_installer_manifest.py -v: no node, npm, npx on PATH (the workflow uses node 24); put node on PATH
  • rom.yml / web-installer: bash -n scripts/release.sh: no node, npm, npx on PATH (the workflow uses node 24); put node on PATH

Notes:

  • GitHub runs Python 3.12; this run used Python 3.9.6

@ymote
ymote merged commit 58185b4 into main Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant