Repository navigation
deps: one octosense-app-contract from crates.io; App Hub by contract version, Rinx v1.1.0 (ADR 0005 step 3) - #243
Merged
Merged
Conversation
ymote
marked this pull request as ready for review
October 1, 2026 05:00
… Rinx to v1.1.0 (ADR 0005) OctoSense ADR 0005, plan step 3: - The workspace depends on octosense-app-contract = "1" (crates.io); the shell takes the manifest, HostLimits, digest_dir and MANIFEST_FILE from it (behind app-hub, and on mobile). Only App Hub-only items (AgentBundle, ToolSpec, IsolateSettings, the Splash adapter, the Hub client) still come from octosense-app-policy / octosense-app-hub. - App Hub moves to 72c8d792 (OctoSense-App-Hub#47's head): its crates name the contract by version, so the build links one copy, from crates.io. - Rinx moves to tag v1.1.0 (hagency-org/Rinx#49), which names no App Hub commit. native-apps.json's rev and the Cargo.lock commit for the tag are #49's head, af3a039f, a placeholder until the tag exists on the merge commit (see the PR). - No www.github.com App Hub alias: main has none, and one contract version makes it unnecessary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… (until #204) App Hub main (58c3c8ae) includes App Hub #38: every ServiceCall carries may_prompt, and App Hub's own sheet handler refuses a sheet when it is false. Before #38 nothing read it and a sheet was always allowed. Every ServiceCall OctoSense builds (the shell's agent tool calls in script_apps.rs, and the services' tests) passes may_prompt: true, so behaviour is unchanged; no OctoSense service reads the field yet. Isolates are unchanged too: App Hub's isolate_settings now sets host_prompts true for a foreground app, so a glance tile's requests carry may_prompt true and its sheets are allowed, as today. Refusing sheets on background surfaces is #204's work. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ymote
force-pushed
the
deps/app-contract
branch
from
October 1, 2026 05:12
730721e to
fd0fa8d
Compare
Pins: this branch's App Hub 58c3c8ae, Rinx v1.1.0 and octosense-app-contract 1.0.0 from crates.io; the www.github.com App Hub alias that #210 restored is removed again (no longer needed). Main's makepad, octos, crates/process-apps member, Sheets bin_features and terminal.run text kept. Cargo.lock: one App Hub source, no duplicate App Hub/contract/Rinx/makepad crates; setup.py --check --cargo and native_apps.py --check pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Local CI passed on e847eec ( GitHub would run for this PR: desktop.yml, phone.yml, apps.yml. Merged on this local pass (macOS runner queue); GitHub CI runs on the merge commit on main.
Notes:
|
ymote
added a commit
that referenced
this pull request
Oct 1, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ymote
added a commit
that referenced
this pull request
Oct 1, 2026
Main's App Hub pin (58c3c8ae, after #243) already contains 954f5da7 (App Hub#38), so this keeps main's root pins, Cargo.lock and native-apps.json, and drops the www alias [patch] section, which main no longer has. - host_tools/script_apps.rs: main's imports and check_script_app_id stay; a tool call now sets may_prompt: false (main's #243 set it to true to keep behaviour unchanged; this branch is the behaviour change). - ai-providers tests/service.rs: main's send, then this branch's send_background. - Other tests already build ServiceCall with may_prompt: true on main. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft. OctoSense ADR 0005, plan step 3: OctoSense, App Hub and Rinx now link one
octosense-app-contract, from crates.io. App Hub changes no longer force a Rinx release, and no App Hub host alias is needed.Independent of #204. This branch is origin/main plus three commits of its own; none of #204's commits or files are in it. It will need main merged in after #210 lands (#210 also moves the App Hub pin and touches
script_apps.rs).Commits
deps: one octosense-app-contract from crates.iooctosense-app-contract = "1". Cargo.lock pins 1.0.0 from crates.io.AppManifest::parse,HostLimits,digest_dirandMANIFEST_FILE. They are behindapp-hub(through native-apps.jsonimplies) and always present on mobile.octosense-app-policy/octosense-app-hub:AgentBundle,ToolSpec,IsolateSettings, the Splash adapter and the HubStore.www.github.comApp Hub alias; main has none.deps: the real commits. App Hub moves to58c3c8ae(Docs: fix a dead anchor in local-ai.md #47 merged; its crates take the contract by version). Rinx moves totag v1.1.0, which is4b89097d(Runtime: OctoScript-Makepad 99c1e5ee (makepad d0a9def5), App Hub 46d67e51, System-Apps d30c67cb #49 merged).shell: fill App Hub #38's ServiceCall.may_prompt, behaviour unchanged (until #204).ServiceCall.may_prompt. App Hub's sheet handler refuses a sheet when it is false; before AI providers system app and the llm host service #38 nothing read it.ServiceCallOctoSense builds passestrue: the shell's agent tool calls and the services' tests.host_prompts: truefrom App Hub'sisolate_settings.Verified locally
cargo tree -dfrom the root and fromphone/: 0 duplicates of octosense-app-contract, octosense-app-policy, rinx or makepad-widgets.cargo tree -i octosense-app-contract: onlyv1.0.0from crates.io.tools/setup.py --check --cargo,tools/native_apps.py --checkand the tools unit tests: OK. Cargo.lock recordsv1.1.0at4b89097d.tools/check-shell-graph.sh -p octosenseand-p octosense-home: OK.cargo build --locked -p octosense: OK.cargo check --locked -p octosense-homewith default,mobile-apps, andmobile-apps,app-appcard): OK.cargo test --locked --features mobile-apps -p octosense-shell -p octosense-home -p octosense-app-policy -p octosense-app-hub -p octosense-appcard -p octosense-ai-hostgives 985 passed, 0 failed.tools/ci-local.sh. The merge captain runs it.Merge order
OctoSense-App-Hub#47 is merged (
58c3c8ae). hagency-org/Rinx#49 is merged (4b89097d) and taggedv1.1.0. This PR goes next: after #210 lands, merge main in, re-run the checks, thentools/ci-local.sh.🤖 Generated with Claude Code