Repository navigation
Close HUB-03, CAL-01 and RUNTIME-01; trim HUB-05 - #231
Merged
Merged
Conversation
HUB-03's fix (930f1b2) had no test. The binary-name lookup moves into find_app_in, which takes the rows, and the_card_binary_names_no_card_runner_app checks that "card" names no Card runner app while another binary still resolves; it fails with the bin != "card" guard removed. CAL-01 is obsolete: first-party apps are script apps (home ADR 0004), a native app needs a reviewed native-apps.json entry (ADR 0004), and the native Calendar source is gone from OctoScript-App-Design-Flow main. RUNTIME-01 is obsolete as written: Maps' native crate and its isolate tests went in #113, and no test or workflow here calls init_cx_os() or skips for it. The entry records that AppleGameInput::init is unchanged at makepad a1c81312. HUB-05 keeps its two open points (is_linked only used by its test; dead android conditions in mobile_surface.rs) with current paths; the launch_module_as log and the duplicate card filter are done.
Contributor
|
Local CI passed on 4d57447 ( GitHub would run for this PR: desktop.yml, phone.yml, apps.yml. Merged on this local pass (macOS runner queue); GitHub CI runs on the merge commit on main.
Notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings four
phone/BACKLOG.mditems up to date withmain(4e88b7d).HUB-03: closed, with the missing test
The fix landed in
930f1b2(2026-09-26):find_app's binary-name fallback skipsbin == "card"rows. The acceptance's test was never added.find_app_in(&[AppDef], id), so the test can pass it rows;find_appcalls it withregistry().the_card_binary_names_no_card_runner_app(crates/shell/src/clients.rs) checks two things:"card"finds none of the Card runner rows, and another binary still resolves.bin != "card"guard removed, the test fails and returnshub:demo.HUB-05: trimmed
Two points remain, with the current
crates/shellpaths:apps::is_linkedis only called by its test.androidis always false inmobile_surface.rs's non-floating navigation branch (mobile_navigation::ENABLED).Recorded as done:
launch_module_aslogs<id> names no app for the card runner.bundled_catalog()filters its rows once, throughcatalog_visible.CAL-01: closed as obsolete
native-apps.jsonentry (ADR 0004).main.A calendar would be a new script app.
RUNTIME-01: closed as obsolete as written
init_cx_os(), and no workflow skips a test for it.The entry records that the framework call is unchanged. At makepad
a1c81312,AppleGameInput::initstill callssetShouldMonitorBackgroundEvents:without checking the thread, so a new off-main-thread test on macOS 14 would trap again.Checks
cargo test --locked -p octosense-shell: 604 passed.phone/,cargo test --locked --features mobile-apps -p octosense-shell: 629 passed.python3 tools/setup.py --check --cargo: OK.rom/tests/test_no_local_paths.py: OK.