Skip to content

test: a running turn is shown to the other lane (octos#2644, in the pin) - #188

Merged
ymote merged 1 commit into
mainfrom
octos-share-running-turns
Sep 30, 2026
Merged

ymote merged 1 commit into
mainfrom
octos-share-running-turns

Conversation

@ymote

@ymote ymote commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

This PR used to repin octos to 66f85fe9, the merge of octos#2644. While it waited, main moved to fe08d8e6 (the merge of octos#2645, in dcc7142), which already includes #2644. So this PR no longer touches the pin, Cargo.toml or Cargo.lock. It now does four things:

  • un-ignores the reproduction test and asserts the final wire;
  • has the two-lane scenario check what it previously only logged;
  • fixes a flaky shell test;
  • updates docs that still named e045c727.

With octos#2644, the shared-history block also shows the other lane's running turn, after the finished rows:

- …Z [from the system agent] SEND_IT
- …Z [the app agent] (in progress) Sending the mail now.
- …Z [turn status] still running, waiting for approval: mail_send

The status line reads still running, still running, waiting for approval: <tool>, or still running, waiting for an answer. It gives tool names only, never arguments. The streamed-text row is left out while the turn hasn't said anything yet.

Changes

  • a_running_turns_request_is_shown_to_the_other_lane is un-ignored (crates/app-peers/tests/real_kernel.rs). It asserts that the last two shared rows are [from the system agent] QUESTION_HOLD and [turn status] still running, waiting for an answer. At e045c727 this test failed with SHARED NONE.
  • Two-lane scenario, step 3c (crates/shell/src/host_tools/scenario_tests.rs). It used to only log what the person's lane saw. It now asserts that the person's lane sees the system agent's running SCN_TASK and waiting for approval: news_share, with no tool arguments.
  • Flaky test fixed: real_kernel_an_allowed_apps_agent_is_prepared_listed_and_shares_its_conversation.
    • It waited for SHARED on the system agent's lane. That can match the turn's own turn/started request (SHOW_SHARED), which arrives before the model's answer.
    • It now waits for SHARED - or SHARED NONE.
    • Locally it failed 1 run in about 4 before this fix, and passed 8 of 8 after.
  • Docs: the pin is now fe08d8e6 wherever the READMEs, ai-services (en and zh-CN), the toolbox README and ADR 0004 still said e045c727. ADR 0004's "Shared history, read-only" item now describes the running turn.

Checks

Run locally on macOS, rebased on main 98666de, with octos built at fe08d8e6 using --no-default-features --features api,git,ast:

  • cargo test --locked -p octosense-app-peers --features octos-core with OCTOS_APP_PEERS_TEST_KERNEL passes, including all 10 real-kernel tests and the un-ignored one.
  • From phone/, cargo test --locked --features mobile-apps -p octosense-shell --lib with OCTOS_SHELL_TEST_KERNEL: 619 passed.
  • The two-lane scenario with OCTOS_SCENARIO_TEST_KERNEL (--test-threads=1): 5 passed.
  • cargo check --locked -p octosense-home (phone) and cargo check --locked -p octosense (desktop) pass.
  • python3 tools/setup.py --check --cargo and python3 -m unittest tools/test_kernel_artifact.py pass.

🤖 Generated with Claude Code

@ymote
ymote force-pushed the octos-share-running-turns branch from 734cf18 to 2673383 Compare September 30, 2026 07:15
main pins octos fe08d8e6 (the merge of octos#2645), which holds octos#2644:
the shared-history block also shows the other lane's RUNNING turn, after
the finished rows: its request with its origin marker, the text it streamed
so far ("[the app agent] (in progress) ..."), and a "[turn status]" line
("still running", "..., waiting for approval: <tool>" or "..., waiting for
an answer"; tool names only).

- Un-ignore app-peers' real_kernel
  a_running_turns_request_is_shown_to_the_other_lane and assert the final
  wire: the last two shared rows are "[from the system agent] QUESTION_HOLD"
  and "[turn status] still running, waiting for an answer".
- The two-lane scenario (shell host_tools::scenario_tests) asserts at 3c
  that the person's lane sees the system agent's running SCN_TASK and
  "waiting for approval: news_share", with no tool arguments.
- real_kernel_an_allowed_apps_agent_is_prepared_listed_and_shares_its_conversation
  waited for "SHARED" on the system agent's lane and could match the turn's
  own request (turn/started, "SHOW_SHARED") before the model's answer; it
  now waits for "SHARED -" or "SHARED NONE" (it failed about 1 run in 4).
- Docs: the pin (fe08d8e6) where the READMEs, ai-services and ADR 0004
  still named e045c727; ADR 0004's shared-history item describes the
  running turn.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@ymote
ymote force-pushed the octos-share-running-turns branch from 2673383 to 48507f9 Compare September 30, 2026 08:46
@ymote ymote changed the title chore: pin octos 66f85fe9 (octos#2644): a running turn is shown to the other lane test: a running turn is shown to the other lane (octos#2644, in the pin) Sep 30, 2026
@ymote
ymote merged commit cf85350 into main Sep 30, 2026
5 checks passed
ymote added a commit that referenced this pull request Oct 10, 2026
App Hub #191 repins App Hub to the same runtime, and with the budget gate
gone a runaway app tool handler still fails at once (a captured-error
sink catches the per-evaluation limit); net alone hands an isolate its
network module. It also brings #186 (components under
wasm-components-v1), #188 (wasi:http and octosense:host admission) and

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant