Repository navigation
test: a running turn is shown to the other lane (octos#2644, in the pin) - #188
Merged
Merged
Conversation
ymote
force-pushed
the
octos-share-running-turns
branch
from
September 30, 2026 07:15
734cf18 to
2673383
Compare
main pins octos fe08d8e6 (the merge of octos#2645), which holds octos#2644:
the shared-history block also shows the other lane's RUNNING turn, after
the finished rows: its request with its origin marker, the text it streamed
so far ("[the app agent] (in progress) ..."), and a "[turn status]" line
("still running", "..., waiting for approval: <tool>" or "..., waiting for
an answer"; tool names only).
- Un-ignore app-peers' real_kernel
a_running_turns_request_is_shown_to_the_other_lane and assert the final
wire: the last two shared rows are "[from the system agent] QUESTION_HOLD"
and "[turn status] still running, waiting for an answer".
- The two-lane scenario (shell host_tools::scenario_tests) asserts at 3c
that the person's lane sees the system agent's running SCN_TASK and
"waiting for approval: news_share", with no tool arguments.
- real_kernel_an_allowed_apps_agent_is_prepared_listed_and_shares_its_conversation
waited for "SHARED" on the system agent's lane and could match the turn's
own request (turn/started, "SHOW_SHARED") before the model's answer; it
now waits for "SHARED -" or "SHARED NONE" (it failed about 1 run in 4).
- Docs: the pin (fe08d8e6) where the READMEs, ai-services and ADR 0004
still named e045c727; ADR 0004's shared-history item describes the
running turn.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ymote
force-pushed
the
octos-share-running-turns
branch
from
September 30, 2026 08:46
2673383 to
48507f9
Compare
This was referenced Oct 10, 2026
ymote
added a commit
that referenced
this pull request
Oct 10, 2026
App Hub #191 repins App Hub to the same runtime, and with the budget gate gone a runaway app tool handler still fails at once (a captured-error sink catches the per-evaluation limit); net alone hands an isolate its network module. It also brings #186 (components under wasm-components-v1), #188 (wasi:http and octosense:host admission) and Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR used to repin octos to 66f85fe9, the merge of octos#2644. While it waited, main moved to fe08d8e6 (the merge of octos#2645, in dcc7142), which already includes #2644. So this PR no longer touches the pin,
Cargo.tomlorCargo.lock. It now does four things:With octos#2644, the shared-history block also shows the other lane's running turn, after the finished rows:
The status line reads
still running,still running, waiting for approval: <tool>, orstill running, waiting for an answer. It gives tool names only, never arguments. The streamed-text row is left out while the turn hasn't said anything yet.Changes
a_running_turns_request_is_shown_to_the_other_laneis un-ignored (crates/app-peers/tests/real_kernel.rs). It asserts that the last two shared rows are[from the system agent] QUESTION_HOLDand[turn status] still running, waiting for an answer. At e045c727 this test failed withSHARED NONE.crates/shell/src/host_tools/scenario_tests.rs). It used to only log what the person's lane saw. It now asserts that the person's lane sees the system agent's runningSCN_TASKandwaiting for approval: news_share, with no tool arguments.real_kernel_an_allowed_apps_agent_is_prepared_listed_and_shares_its_conversation.SHAREDon the system agent's lane. That can match the turn's ownturn/startedrequest (SHOW_SHARED), which arrives before the model's answer.SHARED -orSHARED NONE.fe08d8e6wherever the READMEs, ai-services (en and zh-CN), the toolbox README and ADR 0004 still saide045c727. ADR 0004's "Shared history, read-only" item now describes the running turn.Checks
Run locally on macOS, rebased on main 98666de, with octos built at fe08d8e6 using
--no-default-features --features api,git,ast:cargo test --locked -p octosense-app-peers --features octos-corewithOCTOS_APP_PEERS_TEST_KERNELpasses, including all 10 real-kernel tests and the un-ignored one.phone/,cargo test --locked --features mobile-apps -p octosense-shell --libwithOCTOS_SHELL_TEST_KERNEL: 619 passed.OCTOS_SCENARIO_TEST_KERNEL(--test-threads=1): 5 passed.cargo check --locked -p octosense-home(phone) andcargo check --locked -p octosense(desktop) pass.python3 tools/setup.py --check --cargoandpython3 -m unittest tools/test_kernel_artifact.pypass.🤖 Generated with Claude Code