Repository navigation
Repin makepad bcb0583b (Terminal fixes #61-#65) - #185
Merged
Merged
Conversation
Moves Octoscript-Makepad to 4a641af1 (OctoScript-Makepad#63, the PR head: update to its merge commit once it lands), which pins makepad main bcb0583b: terminal tab titles (#61), wide-character reflow (#62), non-blocking PTY writes (#63), the control-request timeout (#64) and the running-job close confirmation with app_module's close-veto hook (#65). Its runtime.json also carries Octoscript 76032ed4 (OctoScript-Makepad#62), so the Octoscript pins move with it; Cargo.lock gains the one serde edge octoscript-schema now declares. The settings and system-back runtime patches apply to bcb0583b unchanged (none of their files moved since a5a3cf5b); only the base revision and the stacked tree (a5df8528) change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Octoscript-Makepad #63 (makepad bcb0583b) is merged; the lock pointed at its PR head until now. This commit also runs CI on the repin (the earlier commit carried [skip ci] from the ADR 0004 period). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repins the runtime to makepad main
bcb0583b: terminal tab titles (makepad#61), wide-character reflow (#62), non-blocking PTY writes (#63), the control-request timeout (#64), and quit/close confirming running jobs withapp_module's close-veto hook (#65). Part of #179.Before merge:
native-runtime.lock.json(andapps/appcard/native-runtime.lock.json,Cargo.toml) name Octoscript-Makepad4a641af1, the head of OctoSense-org/OctoScript-Makepad#63. Once that PR merges, update them to its merge commit.515acb49→4a641af1. Itsruntime.jsonalso carries Octoscript76032ed4(from OctoScript-Makepad#62, already on its main), so the Octoscript pins move with it.Cargo.lockgains one edge:octoscript-schemanow depends onserde.makepad-settings.patchand the stackedmakepad-system-back.patchapply tobcb0583bunchanged, with the same sha256. None of the files they touch changed betweena5a3cf5bandbcb0583b. Onlybase_revisionand the stacked tree (a5df8528) change.native-apps.json(sheets, terminal) and the regeneratedCargo.tomlblock; doc lines naming the release.Checks (macOS)
python3 tools/setup.py --update, then--check --cargo: clean.cargo check --locked -p octosense: ok.cd phone && cargo test --locked --features mobile-apps -p octosense-shell: 584 passed.cd phone && cargo test --locked --features mobile-apps,app-terminal -p octosense-shell terminal: 14 passed.python3 tools/native_apps.py --check: ok.The shell side of #65 (hosted close confirmation) is stacked on this branch as its own PR.
🤖 Generated with Claude Code