Repository navigation
toolbox: the dossier template; search categories; resolved_url and publisher_host - #172
Merged
Merged
Conversation
…her_host Port the dossier template work from local/research-peer (3cdb777, 2bfbf02, f966c1e) onto current main: - templates/dossier: the template (long-report research: questions with per-question sub-queries over categories, pooled round-robin reads, in-flight reuse across questions, per-question digests) with its two blessed fixtures, plus its library.lock.json entry (digest recomputed; other templates stay at their main versions); - mod.research search categories: SearchQuery.category, narrowed through scope::narrow_search_in (grant-checked, default news), wired through the octos engine backend, the peer's toolbox.search tool (adapted to main's #151 peer.rs catalog code) and the module spec; - resolved_url / publisher_host: the backend's final read URL recorded as resolved_url (null while on an aggregator), the publisher's host in provenance and every template's sources[], runner provenance matching on resolved_url too; - tests updated for the new fields (final_url in test backends, provenance match on resolved_url, dossier in the tool-surface list). Left out of this port: examples/toolbox_run.rs, the toolbox_run example Cargo.toml entry, the version bumps and fixture regenerations for the other templates (briefing, compare, market-brief, news-digest, topic-brief, weather-plan); the new fields are additive and those templates keep their main fixture output. peer.rs keeps main's #151 shape; only the category plumbing was added to it.
…ed reads - peer.rs SEARCH decl: since octos#2610 the metasearch's general category also searches the web (DuckDuckGo, Bing, Brave, Google), so the stale 'Wikipedia, Wikidata' wording is replaced; the dossier manifest names categories only and needed no change. - runner.rs: a Probe backend (records SearchQuery, serves a Google News item whose read ends on the publisher's page) backs three tests: a search in a category the app was not granted is denied with the grant reason and never reaches the backend; a granted category is passed through to the backend as SearchQuery.category; a redirected read reports resolved_url and publisher_host in both the article output and the run's provenance. - templates.rs: the dossier template's two fixtures replay green in a named test. - rustfmt over the port's long call chains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
dossierworkflow template to the system toolbox library (ADR 0002 §6): a long-report research procedure. It was written for the DHH/Omarchy deep-research validation, and it's the first step of moving deep research onto OctoScript workflow templates.The template (
templates/dossier/, 1.1.0): for each question it searches, reads sources, and keeps each quote with its source'sresolved_urlandpublisher_host. It assembles the report as data, so sources and quotes are carried through, never retyped by a model. Two recorded fixtures:two-questions, andfailed-read-and-empty-question.mod.researchadditions it needs:news(default),general,it,science,social, mapped to the octos metasearch categories.generalis general web search: DuckDuckGo, Bing, Brave, Google, Wikipedia (octos#2610). An app may use only the categories in its research grant (scope::narrow_search_in), so this adds no new access.resolved_url/publisher_hoston every article read: the page a read actually ended on, e.g. the publisher behind a Google News link. Also carried in run provenance. This fixes the citation mix-ups found in the DHH validation, where claims were re-attached to the wrong article.research.searchtool for app peers (peer.rs, toolbox-peers: offer the system toolbox to app agents (ADR 0002 §6, ADR 0004 §12, behind a feature) #151) takes an optionalcategory.Tests:
Checks (local, after merging current main):
cargo test --locked -p octosense-toolbox: 80 passed;--features live: 94 (4 ignored);--features octos-engine: 102 (4 ignored).cargo test --locked -p octosense-ai-host --features toolbox-peers: 39 passed.-D warnings(plain andlive,octos-engine) andcargo fmt --checkare clean.How it was made: by an OctoLoop peer agent (octoscode on octos, GLM 5.3 on the GLM Coding Plan), supervised by Claude through a review board in two stages. Claude reproduced every check before opening this PR. The port is from a local branch;
examples/toolbox_run.rs(a CLI to run a template against the live octos engine) is left for a follow-up.🤖 Generated with Claude Code