[ymote]

ADR 0004 gap review, G10 and G5 (medium). Follows #157 (G9), rebased on main after #151, #153 and #158; the local checks ran on the rebased tree.

G10: turning an agent off revokes it live; Settings lists every agent

Before, turning an agent off only recorded the answer. A module kept its injected service, and a process app its contexts, until recreated. Settings also listed only apps that had already asked.

• Revocation. Consent queues every agent turned off: from Settings, or a denial on the first-use sheet. The shell drains the queue whenever approvals change and revokes the live service however the app is hosted:

  • an in-process module's instances lose their assistant, released now (ModuleHost::revoke_assistant);
  • a process app's peer-link contexts close (the app is told agent_turned_off) and its service is released (peer_link::revoke);
  • a contained app's peer is released (contained::revoke).

  Later requests need consent again.

• Settings lists every app that declares an agent, before it ever asks (apps::agent_apps):

  • native apps whose native-apps.json entry grants octos.*;
  • script apps, system and installed, whose manifest declares octos.*.

G5: script-app agents behind consent

Before, script-app agents were off unless OCTOSENSE_CONTAINED_APPS=1, even with consent, and a peer was granted all four octos.* services.

• The gate. ai-host has ContainedGate (Off, Consent, Everyone).
  • The shipped policy is Consent: an app gets its agent once consent::granted(app), and its first call asks.
  • OCTOSENSE_CONTAINED_APPS stays the developer override: 1 turns it on for every app without asking, 0 turns it off.
• Declared services only. A contained app's peer gets only the octos.* services its admitted manifest declares (contained::declared; the shell's lookup is apps::declared_octos, cached per App Hub generation). A call for anything else, or from an app the shell does not know, is refused.

Tests

• turning_an_agent_off_queues_its_revocation_once
• turning_the_agent_off_closes_its_contexts_and_releases_its_service (peer link)
• the module host revokes a live instance's service (in a_granted_module_gets_its_service_at_creation_and_others_get_none)
• turning_an_agent_off_releases_its_live_peer_at_once (contained, with a fresh peer after)
• contained_apps_get_only_the_octos_services_their_manifest_declares
• settings_lists_every_app_that_declares_an_agent_before_it_asks
• policy_contained_apps_follow_consent

Local checks

These all passed:

• cargo check for desktop (default and mobile-apps) and for phone (octosense-home --features mobile-apps)
• cargo test -p octosense-shell --lib on desktop and on phone
• app-peers (octos-core,ws) and ai-host (octos-core,llm) tests
• tools/check-shell-graph.sh for both shells
• tools/setup.py --check --cargo
• tools/native_apps.py --check

🤖 Generated with Claude Code