Repository navigation
Isolate store presentation tests from native HTTPS workers - #211
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The App Hub presentation test manually supplies an SVG download response, but it also starts a real request to
https://example.com/icon.svg. On Linux this creates detached native HTTP/OpenSSL workers that can still run while the test process exits.Use a recording network backend scoped to this test's
Cx. Preserve the simulated response and rendering assertions, and additionally check the request ID, exact URL, GET method, 1 MiB response limit, completed request removal and absence of a second download when the image is cached. No production code changes and no tests skipped.This removes a concrete test-isolation defect discovered while investigating the post-merge Linux failure of run 38118564980: all 48 tests printed PASS before the process exited with SIGSEGV. The exact SIGSEGV cause is not proven without a native backtrace. This PR does not claim to fix every Makepad/OpenSSL shutdown race.
Validation on macOS Apple silicon, plain pinned Makepad d653bc4493619ab979ccff165cf48c0c63b77d19:
cargo test --locked --release -p octosense-app-hub-app --no-default-features --lib: 48 passed, no failures/skips, successful process exit.git diff --checkpassed.Linux and Windows acceptance remains the PR's native-tools CI; local repetitions above were on macOS.