Repository navigation
Reserve updater: OctoSense's native Updates window - #210
Merged
Merged
Conversation
OctoSense's in-app updater (OctoSense #446) is a native module with the id `updater`. Like every native app's id, no store app may take it as its id or namespace (ADR 0004 §3). OctoSense's shell test a_script_app_may_not_take_a_native_apps_id_or_namespace checks this list against its native-apps.json, and fails on #446 until App Hub reserves it. Tested: cargo test --locked -p octosense-app-contract -p octosense-app-policy -p octosense-app-hub (all pass), with makepad d653bc44 and Octoscript-Makepad 6cf2d90a as siblings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OctoSense's in-app updater (OctoSense #446) is a native module with the id
updater. Like every native app's id, no store app may take it as its id or namespace (ADR 0004 §3). This addsupdatertoRESERVED_NAMES, its doc comment and the app-contract 1.12.0 changelog.OctoSense's shell test
a_script_app_may_not_take_a_native_apps_id_or_namespacechecks this list againstnative-apps.json; it fails on #446 until App Hub reserves the name. No App Hub code or test usesupdater.Tested:
cargo test --locked -p octosense-app-contract -p octosense-app-policy -p octosense-app-hub, all passing, with makepadd653bc44and Octoscript-Makepad6cf2d90aas siblings.🤖 Generated with Claude Code