Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App Hub left Get in the detail header while placing the actual Install button below the permissions and privacy copy. The header now uses one primary action: Get → Install → Installing… → Open. Choosing Get reveals the disclosures; choosing Install submits the existing catalog-bound consent. The footer retains Cancel, and update listings retain their separate Open action for the installed version.
Installation results and catalog warnings appear below the detail header so they cannot move the primary button. Entering consent from an already open detail page preserves its scroll position. The native preview now logs verified installed-app open actions as well as built-in launches.
Validation:
cargo test --locked --release -p octosense-app-hub-app --no-default-features --lib: 48 passed.cargo build --locked --release -p octosense-app-hub-app --no-default-features --examples: passed against the pinned plain Makepad siblings.The native checks use isolated local catalogs and profiles. Early harness attempts needed search-layout settling and scrolling before checking narrow-screen disclosure visibility; completed runs cover all three sizes. Preview checks establish Open dispatch, not full-shell app launch. No Android device run is claimed.
OctoSense must adopt this App Hub commit and ship a new host build for released users to get the fix. The existing RC5 app and public catalog are unchanged.