Repository navigation
chore: unblock CI on this branch — rustfmt, catalog drift, clippy - #7
Merged
Merged
Conversation
`cargo fmt --check` is the first step of CI, so this one unformatted file has been failing every job on the branch — including PRs that touch nothing near it. Formatting only, no behaviour change. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Same reason as the previous commit: `cargo fmt --check` gates every other CI step, and two crates were carrying formatting debt that failed jobs touching neither. Formatting only. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…ear clippy Three things standing between this branch and a green CI, none of them related to each other beyond blocking every job. `sys.wiki` was added to the Rust catalog without an entry in `ui-l0-constructors.toml`, so the spec and the code disagreed about what sources exist. Documented. Its vocabulary offered `thumbnail`, and no lowering answered it: the page-summary endpoint returns that as a nested object (`thumbnail.source`) while every lowering here reads a single flat field. A card asking for `d.thumbnail` got an em dash with nothing able to warn it — which is precisely the failure `every_offered_field_has_a_translation` exists to catch. The field is withdrawn rather than half-answered; adding it back needs a nested-path lowering first. Two clippy warnings cleared, because CI runs it with `-D warnings` and fmt was short-circuiting before it ever got there. 263 passed, 0 failed, 0 clippy warnings, 0 fmt diffs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ymote
changed the title
CI pins nothing — `dtolnay/rust-toolchain@stable` — so a new clippy release fails the branch without a line of code changing. 1.98 added `chunks_exact_to_as_chunks` and tightened `field_reassign_with_default`, and `-D warnings` turns both into build failures. Three `chunks_exact(N)` call sites become `as_chunks::<N>().0`, which is what the compiler itself suggests and is semantically identical — both drop the same remainder, and every one of these indexes into the chunk, which a fixed-size array still supports. One `ExecutionLimits` built by assignment becomes a struct literal with `..Default::default()`. Verified against the toolchain CI actually uses, not the one that happened to be installed locally — which is how this went unnoticed: 1.95 does not have these lints, so the branch looked clean and CI did not. cargo +1.98 fmt --check 0 diffs cargo +1.98 clippy --workspace -D warnings clean cargo +1.98 test --workspace 1013 passed, 0 failed Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmt --checkis the first step of CI, so this one unformatted file fails every job on the branch — including PRs that touch nothing near it (e.g. #6, which is confined tosplash-ui-l0).Formatting only.
cargo check -p splash-media-hostclean, no behaviour change.Verified locally that
cargo fmt --check -p splash-media-hostreports the same line numbers CI does (237, 326, 359, 381, 442, 464 …), so the local toolchain agrees with the runner's.🤖 Generated with Claude Code