Repository navigation
Fix language execution bounds and semantic regressions - #19
Merged
Merged
Conversation
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uncaught script errors could allow later granted effects to execute; structural equality and empty UI expansion could escape execution bounds. This change makes those paths terminate safely and fixes the operator, block-result, indexing, and JSON semantics reported in the language review.
try/catchstill recovers.~; standalone compatibility evaluation also disables direct VM output.&&above `!always performs logical negation.nil.The stricter error handling exposed latent contract failures. Updating an object field now preserves insertion order, and the existing fixtures explicitly import their assertions and use record iteration for three binders. The patch also includes small existing formatting/lint corrections needed for the workspace quality gate, including fixed-size byte iteration required by Rust 1.98 in the Linux and storage paths.
Behavior changes are published in
docs/grammar.md,docs/language-profile.md, and the UI profile. Vendor changes and their upstream-sync requirements are recorded invendor/makepad/PATCHES.md.Validation:
All GitHub Actions checks pass on
f1e775f: Linux tests, fuzz targets, AddressSanitizer, and Miri.cargo fmt --checkcargo +1.98.0 clippy --workspace --all-targets --all-features -- -D warningscargo +1.98.0 test --locked --workspace --all-featuresmakepad-scriptandmakepad-regexsuites (378 test executions), including streaming and reload coverage.Compatibility: larger integer identifiers must be strings; canonical integer literals and VM JSON integers are limited to +/-9007199254740991. Arithmetic remains binary64. Host-only JSON for schemas and telemetry keeps its integer range. Invalid index coercions and direct script logging are no longer accepted. Linux containment paths were cross-compiled on macOS; live Linux kernel enforcement was not exercised in this environment.
Fixes #9
Fixes #10
Fixes #11
Fixes #12
Fixes #13
Fixes #14
Fixes #15
Fixes #16
Fixes #17
Fixes #18