Skip to content

fix(wallet-core): resolve validation issues 304-307 - #400

Merged
Emmyt24 merged 1 commit into
Octo-Protocol-org:dev-branchfrom
ololadedavidvictor-bit:fix/wallet-core-issues-304-307
Sep 29, 2026
Merged

Emmyt24 merged 1 commit into
Octo-Protocol-org:dev-branchfrom
ololadedavidvictor-bit:fix/wallet-core-issues-304-307

Conversation

@ololadedavidvictor-bit

@ololadedavidvictor-bit ololadedavidvictor-bit commented Sep 29, 2026 •

Copy link
Copy Markdown

Summary

  • Restore the signer module emptied by the latest upstream commit, including positive payment amount validation.
  • Reject sponsored fees below Stellar's minimum before reserving wallet budget.
  • Require exactly 64 bytes for raw BIP-39 seeds and zeroize rejected input.
  • Add regressions for seed lengths, fee boundaries, and corrupted muxed-address checksums.

Closes #304
Closes #305
Closes #306
Closes #307

@drips-wave

drips-wave Bot commented Sep 29, 2026

Copy link
Copy Markdown

@ololadedavidvictor-bit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Emmyt24
Emmyt24 merged commit 2fe6cbd into Octo-Protocol-org:dev-branch Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment