Skip to content

fix: close wallet address and validation issues #295-#298 - #390

Merged
Emmyt24 merged 2 commits into
Octo-Protocol-org:dev-branchfrom
emdy9008:fix-issues-295-298
Sep 28, 2026
Merged

Emmyt24 merged 2 commits into
Octo-Protocol-org:dev-branchfrom
emdy9008:fix-issues-295-298

Conversation

@emdy9008

Copy link
Copy Markdown

Summary

  • Document and independently cover muxed ID 0 and u64::MAX; zero is valid, and the SQL allocator starts at 1 in signed BIGINT. Its transactional increment fails at the signed limit rather than wrapping, so the store cannot allocate u64::MAX.
  • Add a corrupted-character regression for G... strkeys; PublicKey::from_string performs checksum-verifying decoding, and account validation intentionally accepts only base G... accounts.
  • Version ownership challenges as v2 and bind the configured Stellar network passphrase into both the signed payload and HMAC. A challenge from one network is rejected on another; clients continue signing the returned opaque challenge string.
  • Reject XLM and native credit-code spellings case-insensitively under Octo policy, with a distinct error. The added constructor cross-check asserts Asset::new_credit accepts those spellings, so this restriction is explicitly policy rather than a Stellar protocol constraint.

No compile or tests were run, as requested. git diff --check passed.

Closes #295
Closes #296
Closes #297
Closes #298

@drips-wave

drips-wave Bot commented Sep 26, 2026

Copy link
Copy Markdown

@emdy9008 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

…5-298

# Conflicts:
#	crates/api/src/error.rs
@Emmyt24
Emmyt24 merged commit 69618d2 into Octo-Protocol-org:dev-branch Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment