fix: close wallet address and validation issues #295-#298 - #390
Merged
Emmyt24 merged 2 commits intoSep 28, 2026
Merged
Conversation
|
@emdy9008 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…5-298 # Conflicts: # crates/api/src/error.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0andu64::MAX; zero is valid, and the SQL allocator starts at1in signedBIGINT. Its transactional increment fails at the signed limit rather than wrapping, so the store cannot allocateu64::MAX.G...strkeys;PublicKey::from_stringperforms checksum-verifying decoding, and account validation intentionally accepts only baseG...accounts.v2and bind the configured Stellar network passphrase into both the signed payload and HMAC. A challenge from one network is rejected on another; clients continue signing the returned opaque challenge string.XLMandnativecredit-code spellings case-insensitively under Octo policy, with a distinct error. The added constructor cross-check assertsAsset::new_creditaccepts those spellings, so this restriction is explicitly policy rather than a Stellar protocol constraint.No compile or tests were run, as requested.
git diff --checkpassed.Closes #295
Closes #296
Closes #297
Closes #298