Skip to content

Fix webhook retries, empty config updates, and ingest alerts - #389

Merged
Emmyt24 merged 2 commits into
Octo-Protocol-org:dev-branchfrom
Gospelsam019:fix/issues-311-314
Sep 28, 2026
Merged

Emmyt24 merged 2 commits into
Octo-Protocol-org:dev-branchfrom
Gospelsam019:fix/issues-311-314

Conversation

@Gospelsam019

@Gospelsam019 Gospelsam019 commented Sep 26, 2026 •

Copy link
Copy Markdown

Summary

  • Stop webhook delivery retries once an endpoint is deactivated, checking its indexed active state before each attempt.
  • Reject empty sponsorship and whitelist config updates with a consistent 400 response and document the behavior.
  • Confirm the public payment-link slug equality lookup is backed by the existing unique index; no redundant index is added.
  • Include the wallet ID in error-level alerts when a per-wallet ingest task panics. The existing bounded concurrent tick continues servicing other wallets and retries on later ticks.

Verification

  • git diff --check passed.
  • Per request, no compilation or tests were run. EXPLAIN ANALYZE was also not run; the existing unique constraint provides the B-tree index for the current exact-match query.

Closes #311
Closes #312
Closes #313
Closes #314

@drips-wave

drips-wave Bot commented Sep 26, 2026

Copy link
Copy Markdown

@Gospelsam019 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

…1-314

# Conflicts:
#	crates/ingest/src/lib.rs
#	crates/store/src/lib.rs
#	crates/webhooks/src/lib.rs
#	docs/api.md
@Emmyt24
Emmyt24 merged commit 93887ed into Octo-Protocol-org:dev-branch Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment