Skip to content

Fix concurrent gas-tank provisioning and wallet/webhook validation - #385

Merged
Emmyt24 merged 2 commits into
Octo-Protocol-org:dev-branchfrom
Jonniclux2618:fix/issues-315-316-318-299
Sep 28, 2026
Merged

Emmyt24 merged 2 commits into
Octo-Protocol-org:dev-branchfrom
Jonniclux2618:fix/issues-315-316-318-299

Conversation

@Jonniclux2618

@Jonniclux2618 Jonniclux2618 commented Sep 26, 2026 •

Copy link
Copy Markdown

Summary

  • Serialize gas-tank provisioning with a wallet row lock so concurrent requests do not generate duplicate tank keypairs; preserve the final conditional update and return a conflict to the loser.
  • Require imported mnemonics to derive the caller-claimed account and keep WalletError output free of secret material.
  • Reject direct webhook URLs targeting the configured PUBLIC_API_URL host. This best-effort check does not prevent indirect loops through alternate hosts or proxies.

Verification

  • git diff --check passed.
  • Compilation and tests were not run, as requested.

Closes #315
Closes #316
Closes #318
Closes #299

@drips-wave

drips-wave Bot commented Sep 26, 2026

Copy link
Copy Markdown

@Jonniclux2618 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

…5-316-318-299

# Conflicts:
#	crates/api/src/routes/wallets.rs
@Emmyt24
Emmyt24 merged commit 2a2de6b into Octo-Protocol-org:dev-branch Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment