You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
bug(scanner): validate AZ-SC-001 through AZ-SC-004 against real ACR SDK models #301
The Azure client returns real azure.mgmt.containerregistry.models.Registry objects, whose relevant fields are top-level. AZ-SC-001 through AZ-SC-004 instead read registry.properties; tests reproduce that incorrect nested shape.
Real registries can therefore be silently skipped. AZ-SC-004 also applies retention expectations to Basic/Standard registries even though the retention feature is Premium-only.
Evidence: scanner/azure_client.py:932-955, scanner/rules/az_sc_001.py:38-46, az_sc_002.py:39-47, az_sc_003.py:39-47, az_sc_004.py:42-65, and tests/test_rules_supply_chain.py:27-37.
@ritiksah141, once the #293 namespace-exclusion correction is pushed, please post your initial approach for #301 before implementation. In particular, confirm how you will test real azure.mgmt.containerregistry.models.Registry instances, Premium-only retention applicability, and 403/429/partial collection without converting unavailable evidence into a clean result. That will let us catch contract issues before the four ACR rules are rewritten.
Activity
m-khan-97 commentedon Aug 24, 2026
@ritiksah141, once the #293 namespace-exclusion correction is pushed, please post your initial approach for #301 before implementation. In particular, confirm how you will test real azure.mgmt.containerregistry.models.Registry instances, Premium-only retention applicability, and 403/429/partial collection without converting unavailable evidence into a clean result. That will let us catch contract issues before the four ACR rules are rewritten.
ritiksah141 commentedon Aug 24, 2026
@m-khan-97, will do that once the #293 lands and will share the plan before the execution.
github-actions commentedon Sep 24, 2026
This issue has been inactive for 30 days and will be closed in 7 days unless there is activity.
github-actions commentedon Oct 1, 2026
Closing due to inactivity. Feel free to reopen if still relevant.