Repository navigation
OGRLayer: Fix AttributeFilterEvaluationNeedsGeometry() accounting for GeomFields of feature. - #15435
Open
wslaghekke wants to merge 1 commit into
Open
wslaghekke wants to merge 1 commit into
wslaghekke wants to merge 1 commit into
Conversation
… GeomFields of feature. The method only accounted for the special fields and not the geometry fields themselves. Downstream effect from this in ogr_shape is that it can return the wrong count for filters that refer to geometry fields, because it used this method to skip parsing of geometry in the feature count path
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The AttributeFilterEvaluationNeedsGeometry() method only accounted for the special fields and not the geometry fields themselves. Downstream effect from this in ogr_shape is that it can return the wrong count for filters that refer to geometry fields, because it used this method to skip parsing of geometry in the feature count path.
This also causes the shapefile code to return a wrong feature count if a filter refers to the geometry field, so i wrote a test to prove / validate that.
Reproduction path for that is as simple as passing it any shapefile with geometry and filtering on geometry not being null, we expect the number of features with geometry but that always returns 0 in the old code
ogrinfo -so poly.shp poly -where '"_ogr_geometry_" IS NOT NULL'What are related issues/pull requests?
AI tool usage
Claude helped me verify this issue, i wrote all the code and ran tests.
Tasklist