Repository navigation
[FIX] OpenFileGDB: read default value of non-editable fields - #15385
Merged
Merged
Conversation
Contributor
Author
Contributor
Author
|
@elpaso why the "Windows builds / windows_build (Visual Studio 17, 2022, rel..." failed at It seems a pipeline error? Isn't it? |
Member
|
Yes, it's a random failure. I restarted that job manually. |
Contributor
Author
|
@dbaston is it enough to trigger and wait the last step "Code Checks / cmake-lint..." and then it is merged? Or do I need to add something else to the PR? |
dbaston
reviewed
Oct 20, 2026
Contributor
Author
|
I've just fixed the linting issue on the comment after removing the inner IF |
dbaston
reviewed
Oct 21, 2026
dbaston
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes opening of OpenFileGDB tables that contain a field that is not editable but still stores a default value. Such tables were reported as an empty layer (0 features, no fields).
This layout is seen in ArcGIS Utility Network geodatabases, e.g. the
ASSOCIATIONSTATUSfield.Cause
In
FileGDBTable::Open(), the bytes of a field's default value were only consumed when the field had theEDITABLEflag. For a field with flags0x02(required, not editable) followed by a non-zero default value length, the default value was not skipped, so parsing of the field definitions shifted bydefaultValueLengthbytes:The name length of the next field (22) was then read as its field type, giving:
and the table failed to open.
What are related issues/pull requests?
Fixes #14910
AI tool usage
Tasklist
Environment