Add unit test for partitions with TRES=(null) (#864) - #950
Merged
Conversation
Bubballoo3
previously requested changes
Jul 29, 2026
Bubballoo3
left a comment
Bubballoo3
left a comment
Contributor
There was a problem hiding this comment.
I think the test content looks good, just a few minor points on fixture placement and style
johrstrom
approved these changes
Jul 31, 2026
johrstrom
left a comment
johrstrom
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks to fixing this and thanks @Bubballoo3 for the review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a unit test and fixture to verify that the Slurm adapter correctly parses partitions when TRES=(null). This ensures adapter.queues handles unconfigured or null TRES values gracefully without throwing exceptions.
Related issue
Fixes #864
Testing
Checklist
Anything else?
spec/fixtures/output/slurm/scontrol_show_part_tres_null.txt fixture containing output with TRES=(null).
test_queues_with_tres_null test method in test/job/adapters/slurm_test.rb.