Feature/wayvnc - #944
Conversation
|
@johrstrom @Oglopf @treydock any thoughts on this PR? |
| cat > "#{wayvnc_config}" <<WAYVNC_CONF | ||
| enable_auth=true | ||
| password=${password} | ||
| relax_encryption=true | ||
| allow_broken_crypto=true | ||
| WAYVNC_CONF |
There was a problem hiding this comment.
Can we fix this up a little in formatting to use <<- or similar so we don't have this indentation?
There was a problem hiding this comment.
I fixed the indent as requested.
| if [[ -d "/run/user/$(id -u)" && -w "/run/user/$(id -u)" ]]; then | ||
| export XDG_RUNTIME_DIR="/run/user/$(id -u)" | ||
| else | ||
| export XDG_RUNTIME_DIR="/tmp/ood-runtime-$(id -u)" |
There was a problem hiding this comment.
This should likely use $TMPDIR instead of just /tmp, I know slurm provides it's own per job tmp dir.
There was a problem hiding this comment.
I think /tmp is actually better, as it's almost always present where as $TMPDIR is a site setting that not everyone may use. Even with Slurm's private namespace for /tmp, the path we use is TMPDIR=/tmp.
There was a problem hiding this comment.
I can just check for $TMPDIR and use it if present.
There was a problem hiding this comment.
This now uses $TMPDIR, falling back to /tmp if not present.
4 participants
What does this PR do?
Adds a
wayvncbatch_connect template to support wlroots based compositors.Related issue
Closes #943
Testing
Checklist
Anything else?
wayvnc0.10 is required for DES authentication. There are built packages for EL10 at my Copr repo or build withmock/rpgkusing specs.Example app using labwc at https://github.com/mattmix/bc_wayland_example. Requires labwc, waybar, swaybg, and nwg-drawer to be installed. Copr repo or specs.