fix: escape dotted and dollar-prefixed keys in task upserts - #353
Open
JaimeCernuda wants to merge 7 commits into
Open
JaimeCernuda wants to merge 7 commits into
JaimeCernuda wants to merge 7 commits into
Conversation
Main <- Dev
insert_and_update_many_tasks writes tasks through an aggregation-pipeline $set, which rejects '.' or a leading '$' in any nested key (server error 16412) and fails the whole bulk_write batch. Payload keys are now escaped with fullwidth lookalikes before building the update ops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #352.
insert_and_update_many_taskswrites tasks through an aggregation-pipeline$set, which rejects.or a leading$in any nested key (server error 16412) and fails the wholebulk_writebatch. This escapes such keys with fullwidth lookalikes (．/＄) before building the update ops, and adds a test that inserts a task with ayr.doypayload key.Happy to switch the escaping convention if you prefer a different one.