Repository navigation
Prepare/1.16.0 - #1443
Merged
Merged
Prepare/1.16.0#1443
Conversation
The dynamic variant of the hand-written stage-1m pattern referenced the SDK 2 rule ids (rule|text|R-*), which are usage=sdk2 and therefore absent from the SDK 1 translations, so all 24 of its messages were unresolvable. The static variant was corrected to the SDK 1 ids under TEDEMD-1066 for 1.16.0-rc.2, but the dynamic one was left as it was. Both files now carry the same 24 SDK 1 ids and are byte-identical. The rule contexts, XPath tests and diagnostics references were already identical, so the change is limited to the 24 assert lines. One assert also carried a different id between the two files: the Company rule was id="R-AR0-OPR" in dynamic and id="BR-OPT-00200-0104" in static, while the other 23 already agreed. It is now BR-OPT-00200-0104 in both, so the same rule no longer reports under a different code depending on the folder. All 24 message references now resolve in translations/, in both folders.
pdonohoe
approved these changes
Oct 23, 2026
YvesJo
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK 1.16.0-rc.4
schematrons/dynamic/validation-stage-1m.schstill used the SDK 2 rule ids (rule|text|R-*), which areusage=sdk2and absent from the SDK 1 translations, so its 24 messages did not resolve. The static variant was corrected to the SDK 1 ids under TEDEMD-1066 for rc.2; the dynamic one is now aligned and the two files are identical. All 24 references resolve from both folders.Also corrects one assert id: the Company rule was
R-AR0-OPRin dynamic andBR-OPT-00200-0104in static. Both now useBR-OPT-00200-0104.Everything else is a version re-stamp (
sdkVersionandcreatedOnonly);translations/is unchanged.