Repository navigation
Prepare/1.16.0 - #1441
Merged
Merged
Prepare/1.16.0#1441
Conversation
pdonohoe
previously approved these changes
Oct 21, 2026
rousso
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK 1.16.0-rc.3
Why another candidate
rc.2 shipped with the 24 manually maintained stage-1m rules (TEDEMD-1066) referencing rule-message labels that were not present in the exported translations — the gap documented in this comment on #1440. Those 24 messages would not resolve for a consumer of the SDK.
The cause turned out to be rule status, not the label data. The labels existed in the MDD all along, hand-authored and fully translated — which is why they were visible to the team — but all 24 rules were draft. The translations export withholds a rule|text label whose rule is not published, so they were filtered out at export time.
What changed
The 24 rules were set to published in the MDD. The export now carries their labels: 576 entries, 24 rules × 24 languages, and all 24 stage-1m asserts resolve. That is the entirety of the intended content change in this candidate.
A side effect that had to be fixed first
Publishing the rules also pulled them into
fields.json
, because the fields export applies no stage filter: 19 fields gained an unscoped mandatory constraint (no noticeTypes, no condition), which would have made them mandatory in every notice type they appear in — BT-706-UBO in 16 notice types instead of E4/E5 only.
That is an MDM defect, fixed under TEDEFO-5291: validation stage 1 is preparatory and must not describe field metadata. fields.json in this PR is therefore identical to rc.2 apart from sdkVersion and createdOn — 298 fields carry a mandatory block, exactly as in rc.2.