Repository navigation
Prepare/1.16.0 - #1435
Merged
Merged
Prepare/1.16.0#1435
Conversation
… export The SDK export regenerates both static and dynamic complete-validation.sch from the database, which does not know about the manually written stage-1m. The export therefore removed, in each file, the 51 per-phase <active pattern="EFORMS-validation-stage-1m" /> entries and the <include href="validation-stage-1m.sch"/>, leaving the stage present in schematrons.json and on disk but activated by no phase. Without this the TEDEMD-1066 cardinality rules never run, and the fields they cover (BT-13713-LotResult, BT-191-Tender, BT-556-NoticeResult, BT-651-Lot, BT-686-LotResult, BT-706-UBO, BT-712(b)-LotResult, BT-752-Lot-ThresholdNumber, BT-759-LotResult, BT-773/779/780/782-Tender, BT-792-Review, BT-799-ReviewBody) would have no presence enforcement at all, since the XSD presence was relaxed under TEDEMD-1034 and this export also dropped their generated diagnostics. Restores the wiring to its state in fe3602c, byte for byte. Pending a decision on whether the database and exporter should own this stage (see the discussion on PR #1414), this step must be repeated after every export.
…lt values Applies the change from the reviewed 3-1-rc-default-values.json attached to TEDEMD-1031: "_repeatable": true is removed from GR-Lot and from GR-Part. Only the semantic change is taken; the attachment's 2-space indentation is not, so the repo keeps the 3-space style it shares with address.json. Verified by comparing parsed structures: 149 nodes before and after, none added or removed, and these two attributes the only difference. This file is reserved for TED applications and is not intended for use by eSenders or other third parties.
pdonohoe
previously approved these changes
Oct 2, 2026
encampaen
previously approved these changes
Oct 2, 2026
Completes the previous commit, which restored the stage-1m phase activations
but not the diagnostics. The SDK analyser then reported 48 errors
("Schematron assert has no diagnostic definition", 24 per folder): the
stage-1m asserts were active again but their diagnostic definitions were
still missing.
The export removes both halves of the manual edit made by PR #1414: the 51
per-phase <active pattern="EFORMS-validation-stage-1m" /> entries plus the
<include>, and the 24 <diagnostic> elements, one per stage-1m assert. The
ticket's note that diagnostics are "not modified" refers to the pre-existing
generated ones; these 24 were added by that PR.
Both files are now rebuilt from fe3602c and carry only the export's two
genuine changes: the cbc namespace declaration re-quoted with single quotes,
and ND-LotTender_BT-773-Tender's xpath simplified to
efac:SubcontractingTerm/efbc:TermCode (matching the same predicate removal in
fields.json). Verified: 76 of the 77 lines PR #1414 added to each file are
present verbatim (the 77th being that re-quoted namespace line), all 24
stage-1m diagnostic references resolve, and validation-stage-1m.sch and
schematrons.json are unchanged from the baseline.
YvesJo
previously approved these changes
Oct 5, 2026
pdonohoe
self-requested a review
October 5, 2026 07:52
pdonohoe
previously approved these changes
Oct 5, 2026
YvesJo
previously approved these changes
Oct 8, 2026
pdonohoe
previously approved these changes
Oct 8, 2026
pdonohoe
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.