Repository navigation
feat: account 0.1 - #67
Conversation
✅ Deploy Preview for device-database-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bb463b3 to
ac6f618
Compare
|
Added UI, hidden behind Solved dynamic content in prerendered pages by attaching frontend/src/layouts/Layout.astro Lines 47 to 59 in ac6f618 |
PhilipTrauner
left a comment
PhilipTrauner
left a comment
There was a problem hiding this comment.
some minor nits, but overall this is great 🙌
thanks especially for wrapping your head around the necessary caching invariants for this
| <a | ||
| class="account-provider" | ||
| href={signInHref} | ||
| data-astro-reload | ||
| data-astro-prefetch="false" | ||
| > | ||
| <GitHubMark width="18" height="18" class="icon" aria-hidden="true" /> | ||
| GitHub | ||
| </a> |
There was a problem hiding this comment.
text is currently not visible until hovering 😅
There was a problem hiding this comment.
Not sure how I missed this! Fixed
| // account name missing, re-authentication required | ||
| // checked before refreshing, which would use up the refresh token | ||
| const login = cookies.get(GITHUB_COOKIE_USER)?.value; | ||
| if (typeof login === "undefined") { | ||
| GitHubOAuth.session.clear(cookies); | ||
| return status(401, SESSION_CHANGE_HEADERS); | ||
| } |
There was a problem hiding this comment.
make sense to move this here instead 👌
Co-authored-by: philip trauner <philip.trauner@arztpraxis.io>
Co-authored-by: philip trauner <philip.trauner@arztpraxis.io>
85ac5fe contains the server-side bits of account 0.1
should be rebased on top of #66 so it can be feature-gated, as we don't yet have the required legal copy in place