[19.0][IMP][WIP] endpoint_route_handler: memoize route version per request#140
Open
JordiBForgeFlow wants to merge 1 commit into
Open
[19.0][IMP][WIP] endpoint_route_handler: memoize route version per request#140JordiBForgeFlow wants to merge 1 commit into
JordiBForgeFlow wants to merge 1 commit into
Conversation
Contributor
|
Hi @simahawk, |
OCA-git-bot
added
series:19.0
mod:endpoint_route_handler
JordiBForgeFlow
changed the title
MiquelRForgeFlow
force-pushed
the
19.0-imp-endpoint_route_handler-version-memo
branch
3 times, most recently
from
76db789 to
7319791
Compare
_endpoint_route_last_version() is part of the routing_map ormcache key, so it runs on every routing map access -- e.g. once per url_for while rendering a website page, which adds up to dozens of identical 'SELECT last_value FROM endpoint_route_version' round-trips per page on content-heavy sites. The version cannot change within a request: memoize it on the request object.
MiquelRForgeFlow
force-pushed
the
19.0-imp-endpoint_route_handler-version-memo
branch
from
7319791 to
5278835
Compare
simahawk
reviewed
Jul 1, 2026
| request = http.request | ||
| if not request: | ||
| return cls._get_routing_map_last_version(http.request.env) | ||
| version = request.__dict__.get(cls._endpoint_route_version_attr) |
Contributor
There was a problem hiding this comment.
are we sure there's no better way than accessing __dict__? I tend to think the mocking is wrong somehow.
You could deleted it beforehand:
>>> from unittest.mock import MagicMock
>>> my_mock = MagicMock()
>>> del my_mock.missing_attr
>>> getattr(my_mock, "missing_attr", "default")
'default'
>>> getattr(my_mock, "missing_attr", "default")
'default'
>>> my_mock.missing_attr = 1
>>> getattr(my_mock, "missing_attr", "default")
1
Is that what you are looking for?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_endpoint_route_last_version() is part of the routing_map ormcache key, so it runs on every routing map access -- e.g. once per url_for while rendering a website page, which adds up to dozens of identical 'SELECT last_value FROM endpoint_route_version' round-trips per page on content-heavy sites. The version cannot change within a request: memoize it on the request object.