[18.0][IMP] fs_folder: Don't raise an error when the value is invalid or un…#635
Draft
lmignon wants to merge 2 commits into
Draft
[18.0][IMP] fs_folder: Don't raise an error when the value is invalid or un…#635lmignon wants to merge 2 commits into
lmignon wants to merge 2 commits into
Conversation
…available When the value of a fs_folder field is invalid or unavailable, it will now return a FsFolderInvalidValue or FsFolderUnavailableValue object instead of raising an error. This allows for more graceful handling of these cases in the code and more importantly, it will no longer break the form view when the value is invalid or unavailable.
Contributor
Author
|
ping @xavier-bouquiaux |
when reading the object the js was not aware of this new isInvalid or is Unavailable -> add it to the if the wrong method was called in the xml, trying to physically remove the folder that we know does not exists on the fs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…available
When the value of a fs_folder field is invalid or unavailable, it will now return a FsFolderInvalidValue or FsFolderUnavailableValue object instead of raising an error. This allows for more graceful handling of these cases in the code and more importantly, it will no longer break the form view when the value is invalid or unavailable.