[16.0][ADD] image_tag_environment: make server_environment an optional dependency#575
[16.0][ADD] image_tag_environment: make server_environment an optional dependency#575yankinmax wants to merge 2 commits into
Conversation
| "data": [ | ||
| "views/image_tag.xml", | ||
| ], | ||
| "auto_install": True, |
There was a problem hiding this comment.
Is it enough to get it automatically installed on environments where image_tag was already instealled and it only gets an update?
There was a problem hiding this comment.
I've added the migration script and it's safe enough. No issues in logs about fields removal or schema change.
yankinmax
force-pushed
the
16-dr-image_tag
branch
from
7edd618 to
de71141
Compare
| [("name", "=", "image_tag_environment"), ("state", "=", "uninstalled")] | ||
| ) | ||
| if module: | ||
| module.button_install() |
There was a problem hiding this comment.
My experience also states that it is nice to get the data and add it to the right field. This happened to me and I would recommend you to do it this way 😉
There was a problem hiding this comment.
Which data? the one set in the environment?
The purpose of this script is to install the new split off module, so instances that were configured through the environment remain configurable through env -- by having the new *_environment module automatically installed
Users or sysadmins are expected to explicitly uninstall the *_environment module and re-configure their system.
To make that easier, we're working on this approach:
- [IMP] mail_environment: add uninstall hook server-env#262
- [IMP] server_environment: module uninstallation server-env#261
It's not done in this PR, though. At this stage we want at least to have the modules split.
There was a problem hiding this comment.
yes, but it will give you problems when you want to remove the environment, also, it happened to me that I decided to remove the dependancy as it was not required, at that moment, everything failed as the uninstall hook did not pass.... I am just warning, it shouldn't be a big deal to handle in the migration too.
etobella
left a comment
etobella
left a comment
There was a problem hiding this comment.
For me OK, just review my comment if possible 😉
|
This PR has the |
4 participants
PR is aimed to remove
server_environmentdependency fromimage_tagin the scope of this issue: