[18.0][FIX] session_db: revoking and cleanup of user devices#3662
Conversation
|
Hi @sbidoul, |
tarteo
force-pushed
the
18-fix-session-db
branch
from
b82d985 to
216e6e7
Compare
|
@lal-solute do you want to be added to contributors as well? If so, please let me know what you want me to add to the CONTRIBUTORS.md |
|
@sbidoul perfect, I'll backport that instead for consistency and apply my added tests upon that. |
tarteo
force-pushed
the
18-fix-session-db
branch
2 times, most recently
from
45e72d0 to
2513426
Compare
… 19.0) [IMP] Add tests to test res.device with PGSessionStore
tarteo
force-pushed
the
18-fix-session-db
branch
from
2513426 to
0b178c1
Compare
| raise ValueError( | ||
| "Identifier format incorrect, " | ||
| "did you pass in a string instead of a list?" | ||
| ) |
There was a problem hiding this comment.
Odoo does continue instead of raise in such case. Should we do the same here?
There was a problem hiding this comment.
Yes I wondered why we would need to check the format: #3415 (comment)
There was a problem hiding this comment.
There is a comment in the same function in Odoo explaining why, IIRC. A security protection.
…identifiers instead
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 54ec915. Thanks a lot for contributing to OCA. ❤️ |
|
Thanks @tarteo! Do you plan to forward port? |
|
@sbidoul In 19.0 |
|
Aah, yes. And it looks like I had implemented myself, and there are tests for that already :) Sorry for the noise. All good then, thanks for your help. |
3 participants
For lack of a contributor section I've added my company to the authors key.
Fixes: #3661