[vgavinas]

Fixes #319.

The condition() of the open-gw-new-partner and open-gw-profile thread actions started an async searchRead and then called owner.render(). Conditions are evaluated on every render, so DiscussContent was re-rendered while still mounting and the Owl fiber never completed: Discuss showed no messages in any channel, without any error in the console.

Now the gateway partner of the channel and its single guest (if any) are sent with the channel store data (gateway_partner_id, gateway_guest_id), and the conditions only read them. After the guest is managed, the channel data is fetched again, so "Open Contact" replaces "New Partner" without reloading.

Tested on Odoo 19.0 CE with oca/mail 19.0 + #321 and a live WhatsApp Cloud API test number: Discuss shows the messages again, "New Partner" is shown for a guest sender and becomes "Open Contact" after creating the partner. mail_gateway tests: 0 failed, 0 errors (2 tests added).

[vgavinas]

@CarlosRoca13 Good point, thanks — done: _to_store now searches res.partner.gateway.channel once for the whole recordset. The single-record helpers are kept (used in the tests), and the if not record: continue is gone.

[pedrobaeza]

@etobella please check this important change

[carlos-lopez-tecnativa]

This error probably isn't related to this PR, but since the migration PR has been merged, could you check it? When I tested without this PR, the error didn't appear, but now, with these changes, I get this error. Maybe I just didn't notice it before and it was already there. I think it's more related to the migration.

[carlos-lopez-tecnativa]

These changes fix the error:

diff --git a/mail_gateway/static/src/core/common/message_model_patch.esm.js b/mail_gateway/static/src/core/common/message_model_patch.esm.js
index 1866de703..df00b207d 100644
--- a/mail_gateway/static/src/core/common/message_model_patch.esm.js
+++ b/mail_gateway/static/src/core/common/message_model_patch.esm.js
@@ -1,6 +1,6 @@
 import {Message} from "@mail/core/common/message_model";
 import {patch} from "@web/core/utils/patch";
-import {stateToUrl} from "@web/core/browser/router";
+import { router } from "@web/core/browser/router";
 import {url} from "@web/core/utils/urls";
 
 patch(Message.prototype, {
@@ -13,7 +13,7 @@ patch(Message.prototype, {
             return super.resUrl;
         }
         return url(
-            stateToUrl({
+            router.stateToUrl({
                 model: this.gateway_thread_data.model,
                 resId: this.gateway_thread_data.id,
             })

[etobella]

Technically and functionaly ok.

According to AI Policy, Claude cannot be author/co-author, you should use assisted-by. Can you check that?

[vgavinas]

@etobella Thanks for the review! Done — the commit now uses Assisted-by: Claude Opus 5.5 instead of Co-authored-by.

[luisDIXMIT]

Tested on runboat, LGTM! Thanks for your work!

[vgavinas]

@carlos-lopez-tecnativa Thanks for spotting this — your fix is applied in 8a4c942 (router.stateToUrl). Could you take another look when you have a moment?

[etobella]

/ocabot rebase

[OCA-git-bot]

Congratulations, PR rebased to 19.0.

[etobella]

Sorry to rebase again, but the new CLA Bot is there, and I want to check that everything works nicely

/ocabot rebase

[OCA-git-bot]

Congratulations, PR rebased to 19.0.

[oca-cla-bot]

All commit authors signed the Contributor License Agreement.

[etobella]

@vgavinas I think you need to sign the CLA

[vgavinas]

@etobella Done — CLA signed, the check is green now. Thanks!