[19.0][MIG] edi_exchange_template_oca: Migration to 19.0#250
Open
sergijPf wants to merge 98 commits into
Open
Conversation
Member
|
/ocabot migration edi_exchange_template |
Member
|
/ocabot rebase |
Contributor
|
@etobella The rebase process failed, because command |
Member
|
/ocabot migration edi_exchange_template_oca |
sergijPf
force-pushed
the
19.0-mig-edi_exchange_template_oca
branch
from
44d0990 to
23ff6e9
Compare
OCA-git-bot
added
series:19.0
mod:edi_exchange_template_oca
All the other main methods start with 'exchange_'. Make generate respect this convention.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: edi-framework-18.0/edi-framework-18.0-edi_exchange_template_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-18-0/edi-framework-18-0-edi_exchange_template_oca/
Currently translated at 100.0% (35 of 35 strings) Translation: edi-framework-18.0/edi-framework-18.0-edi_exchange_template_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-18-0/edi-framework-18-0-edi_exchange_template_oca/it/
If no explicit code is passed, it must use the code of the type otherwise it will lookup for the 1st matching template by backend type.
Relying on the code by convention was fragile for many reasons. Most important: 1. users have to remember about this convention 2. is not clear which template is going to be used by a specific type With this change we make it more clear and deprecate the old behavior.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: edi-framework-18.0/edi-framework-18.0-edi_exchange_template_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-18-0/edi-framework-18-0-edi_exchange_template_oca/
Currently translated at 100.0% (41 of 41 strings) Translation: edi-framework-18.0/edi-framework-18.0-edi_exchange_template_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-18-0/edi-framework-18-0-edi_exchange_template_oca/it/
Fix the behavior according to the feature ported from v14 and drop the deprecated lookup by code.
It slows down test suites by creating too many things when not needed.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: edi-framework-18.0/edi-framework-18.0-edi_exchange_template_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-18-0/edi-framework-18-0-edi_exchange_template_oca/
Currently translated at 100.0% (42 of 42 strings) Translation: edi-framework-18.0/edi-framework-18.0-edi_exchange_template_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-18-0/edi-framework-18-0-edi_exchange_template_oca/it/
sergijPf
force-pushed
the
19.0-mig-edi_exchange_template_oca
branch
from
23ff6e9 to
f33e03a
Compare
sergijPf
force-pushed
the
19.0-mig-edi_exchange_template_oca
branch
from
f33e03a to
6f08f49
Compare
simahawk
requested changes
Jun 9, 2026
| def _prettify_xml(self, xml_string): | ||
| return etree.tostring(etree.fromstring(xml_string), pretty_print=True) | ||
|
|
||
| def _get_info_provider(self, exchange_record, work_ctx=None, usage=None, **kw): |
Contributor
There was a problem hiding this comment.
@etobella this slipped out of our reviews when moving away from components: it's dead code w/o edi_component_oca.
In fact, this is a part that I wanted to remove anyway because the snippet already allow you to prepare data from where you want w/o needing to define a specific component.
The original idea was to be able to define default "info" components that could be reused.
@sergijPf pls get rid of it in a separate commit. Something like
[REM] edi_exchange_template_oca: get rid of dead code
Meant to work with components only.
simahawk
approved these changes
Jun 23, 2026
simahawk
reviewed
Jun 23, 2026
| from lxml import etree | ||
|
|
||
|
|
||
| def xml_purge_nswrapper(xml_content): |
Contributor
There was a problem hiding this comment.
@sergijPf may I ask you you to test one thing?
The nswrapper trick should be superflous today because to define namespaces you can use this approach
<t xmlns:cac="urn:oasis:names:specification:ubl:schema:xsd:CommonAggregateComponents-2">
<cac:DeliveryParty>
[...]
</cac:DeliveryParty>
</t>
If this works, we can leave behind this trick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
few changes done as per 19.0: