Skip to content

[18.0][FIX] brand_external_report_layout: avoid empty SCSS attachment when no brand exists #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamyShaawat wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0][FIX] brand_external_report_layout: avoid empty SCSS attachment when no brand exists #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions brand_external_report_layout/models/res_brand.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,10 @@ def _get_asset_style_b64(self):
{"brand_ids": self.sudo().search([])},
raise_if_not_found=False,
)
# An empty attachment cannot be read by the assets compiler,
# which breaks the report assets when there is no brand yet.
if not brand_styles.strip():
brand_styles = "/* No brand-specific styles configured */"
return base64.b64encode(brand_styles.encode())

def _update_asset_style(self):
Expand Down
5 changes: 5 additions & 0 deletions brand_external_report_layout/tests/test_brand_external_report_layout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,3 +187,8 @@ def test_brand_document_layout_get_asset_style(self):
)
result = wizard._get_asset_style()
self.assertIsInstance(result, markupsafe.Markup)

def test_asset_style_not_empty_without_brand(self):
self.env["res.brand"].search([]).unlink()
content = base64.b64decode(self.env["res.brand"]._get_asset_style_b64())
self.assertTrue(content.strip())
Loading