Repository navigation
Upgrade simdutf to v9.0.0 - #62
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the vendored simdutf implementation to v9.0.0, aligning the local amalgamated simdutf.h/.cpp with the upstream release.
Changes:
- Bumps simdutf version to 9.0.0 and raises the minimum required standard to C++17.
- Adopts
std::string_viewin several public-facing helpers/metadata APIs (e.g.,to_string, implementationname/description). - Extends Base64 support with a detailed decode API (
base64_to_binary_details) and a C++23_base64user-defined literal.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
cpp/simdutf.h |
Updates public API/types for v9.0.0, adds Base64 “details” APIs and a C++23 _base64 literal. |
cpp/simdutf.cpp |
Updates implementation to match new APIs and adds static-initialization configuration logic plus Base64 “details” entrypoints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simdutf v9.0.0 uses C++17 features such as 'if constexpr' and 'constexpr lambda'. Update the build configuration to use C++17 instead of C++11 to support these features.
From the upstream simdutf CMakeLists.txt, the project requires C++17 or later. The previous build configuration only set the standard for non-MSVC compilers, which could leave MSVC using its default standard (potentially insufficient for C++17 features). This change ensures C++17 is explicitly set for all compilers: - MSVC: /std:c++17 - GCC/Clang: -std=c++17 This aligns with the upstream requirement and improves compatibility on Windows.
|
v9.2.0 has been released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/simdutf/simdutf/releases/tag/v9.0.0