Skip to content

recoll: qt4 -> qt5, fix build - #97570

Merged
worldofpeace merged 1 commit into
NixOS:masterfrom
woffs:recoll-qt5
Sep 9, 2020
Merged

recoll: qt4 -> qt5, fix build#97570
worldofpeace merged 1 commit into
NixOS:masterfrom
woffs:recoll-qt5

Conversation

@woffs

@woffs woffs commented Sep 9, 2020

Copy link
Copy Markdown
Contributor
Motivation for this change

fix recoll for nixos-20.09
(to be backported to release-20.09)
#33239 #97479

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

@worldofpeace
worldofpeace merged commit 7e5991e into NixOS:master Sep 9, 2020
@woffs woffs mentioned this pull request Sep 9, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants