Skip to content

Mixxx: 2.0.0 -> 2.1.0 - #39106

Closed
magnetophon wants to merge 3 commits into
NixOS:masterfrom
magnetophon:mixxx
Closed

Mixxx: 2.0.0 -> 2.1.0#39106
magnetophon wants to merge 3 commits into
NixOS:masterfrom
magnetophon:mixxx

Conversation

@magnetophon

@magnetophon magnetophon commented Apr 18, 2018 •
edited
Loading

Copy link
Copy Markdown
Member
Motivation for this change

Version 2.0.0 doesn't build on nixos-unstable, this does.
Needs #39105

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Apr 18, 2018
@peterhoeg

peterhoeg commented Apr 19, 2018

Copy link
Copy Markdown
Member

Since qt4 is deprecated, please incorporate the mixxx changes from #33239 that move things to qt5.

@magnetophon

magnetophon commented Apr 19, 2018

Copy link
Copy Markdown
Member Author

The mixxx documentation says that building with qt5 is experimental.
Not sure if that's desirable for a program meant for live performance.

@peterhoeg

peterhoeg commented Apr 19, 2018

Copy link
Copy Markdown
Member

2.1 is the last version with support for qt4 ref mixxxdj/mixxx#1526 (comment) so things are moving towards qt5. That being said, there seems to be an issue with qt 5.10.

I think you make a valid point - I'll update my PR to make qt5 optional so people can at least start trying out.

peterhoeg
peterhoeg reviewed Apr 19, 2018
View reviewed changes
Comment thread pkgs/development/libraries/audio/vamp/default.nix Outdated

rec {

vampSDK = stdenv.mkDerivation {

@peterhoeg peterhoeg Apr 19, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you make this vampSDK = stdenv.mkDerivation rec { you can use version properly below.

@magnetophon magnetophon Apr 19, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I don't get what you are saying here.

@peterhoeg peterhoeg Apr 19, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just pushed a commit to your branch.

xeji
xeji suggested changes May 11, 2018
View reviewed changes
Comment thread pkgs/development/libraries/audio/vamp/default.nix
vampSDK = stdenv.mkDerivation {
name = "vamp-sdk-2.5";
vampSDK = stdenv.mkDerivation rec {
name = "vamp-sdk-${version}";

@xeji xeji May 11, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eval fails because version is undefined here (see ofborg checks).

@peterhoeg peterhoeg May 13, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GrahamcOfBorg eval

@magnetophon

magnetophon commented Sep 4, 2018

Copy link
Copy Markdown
Member Author

No longer relevant.

@magnetophon magnetophon closed this Sep 4, 2018
@magnetophon
magnetophon deleted the mixxx branch September 4, 2018 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterhoeg peterhoeg peterhoeg left review comments
+1 more reviewer
@xeji xeji xeji requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@magnetophon @peterhoeg @xeji @GrahamcOfBorg